Adapter Code Coverage workflow: Support Go version upgrades#4760
Open
anishb-ms wants to merge 3 commits into
Open
Adapter Code Coverage workflow: Support Go version upgrades#4760anishb-ms wants to merge 3 commits into
anishb-ms wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this workflow uses pull_request_target, GitHub always runs the master branch's version of the workflow file. This means any PR that upgrades the Go version in go.mod will fail because:
This makes it impossible to upgrade Go via a PR — the adapter coverage check will always block it.
Fix
Swap the step order and use go-version-file to dynamically read the Go version from the checked-out PR code:
This ensures actions/setup-go performs a full installation of whatever Go version the PR requires — no auto-download, no missing tools, no version mismatch.
Impact
Zero risk for current PRs: master's go.mod declares go 1.23.0, so setup-go installs 1.23.x — same behavior as today.
Unblocks future Go upgrades: version upgrades will work automatically without needing to update this workflow.