Skip to content

Adnuntius Analytics Adapter: Adds documentation for the new Adnuntius Analytics Adapter#5726

Merged
ChrisHuie merged 1 commit into
prebid:masterfrom
Adnuntius:addAdnDetails
May 23, 2025
Merged

Adnuntius Analytics Adapter: Adds documentation for the new Adnuntius Analytics Adapter#5726
ChrisHuie merged 1 commit into
prebid:masterfrom
Adnuntius:addAdnDetails

Conversation

@antosarho
Copy link
Copy Markdown
Contributor

🏷 Type of documentation

  • new bid adapter

📋 Checklist

  • Related pull requests in prebid.js or server are linked -> Paste link in this list or reference it on the PR itself
  • For new adapters check submitting your adapter docs

Related pull request: prebid/Prebid.js#12496

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 25, 2024

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit caed917
🔍 Latest deploy log https://app.netlify.com/projects/prebid-docs-preview/deploys/6826dc93846cd6000885bd60
😎 Deploy Preview https://deploy-preview-5726--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup. Some minor requests

Comment thread dev-docs/analytics/adnuntius.md
fpd_supported: true
gvl_id: 855
safeframes_ok: false
multiformat_supported: will-bid-on-any
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove multiformat_supported ? Please add again

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for saving me from myself!

Updated the wrong files because analytics/adnuntius.md and bidders/adnuntius.md can look very similar in an IDE!

All updated now.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reviewers job 😁

muuki88
muuki88 previously requested changes Feb 6, 2025
Copy link
Copy Markdown
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still waiting for the prebid.js PR to get merged

Comment thread dev-docs/analytics/adnuntius.md Outdated

#### Registration

Please visit [adnuntius.com/](https://livewrapped.com/) for more information.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Please visit [adnuntius.com/](https://livewrapped.com/) for more information.
Please visit [adnuntius.com/](https://adnuntius.com/) for more information.

surpiiiiise 😉

Copy link
Copy Markdown
Collaborator

@patmmccann patmmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as mentioned in the pr, please document that the purpose of this adapter is to validate and debug LiveWrapped metrics reported to the publisher

@muuki88
Copy link
Copy Markdown
Contributor

muuki88 commented May 15, 2025

Hi @antosarho

Can you update fix the last outstanding issue?

  1. Fixing the linked - at least I assume you don't want to link to livewrapped
  2. Explain the purpose of the adapter

@antosarho
Copy link
Copy Markdown
Contributor Author

Sorry for the delay -- I've updated the details.

Thank you for your patience!

@ChrisHuie ChrisHuie dismissed stale reviews from patmmccann and muuki88 May 23, 2025 14:17

resolved

@ChrisHuie ChrisHuie merged commit 474224f into prebid:master May 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants