Documentation for 152media RTD module#6135
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
muuki88
added
LGTM
Pending Prebid Module Release
| page_type: module | ||
| module_type: rtd | ||
| module_code : oftmediaRtdProvider | ||
| enable_download : true |
There was a problem hiding this comment.
Is enable_download: true meant to signify to publishers that this module employs third-party script injection as a part of its operation?
And if true, does this meet the definition of "prominent disclosure"?
A Real-Time Data module may load external code if it requires publisher registration and there’s a prominent disclosure on the module documentation
There was a problem hiding this comment.
No no 😁 It means that it can be downloaded from the download page. True is a solid value!
There was a problem hiding this comment.
@muuki88 - thanks!
Do you know if, as this documentation currently stands, there is enough "disclosure" that the RTD module downloads third-party scripts as a part of its work? It looks like pubs have to register with 152media to work with them and their module, so maybe it becomes obvious at that point. Curious what you think.
There was a problem hiding this comment.
You are right 👍 Thanks for pointing this out. Added a suggestion below
There was a problem hiding this comment.
Perfect, I have updated the doc with the suggestion
Updat with disclaimer about external js file Co-authored-by: Muki Seiler <muuki88@users.noreply.github.com>
|
Hi! I wanted to check if this PR can be merged now that the module has been released: https://github.com/prebid/Prebid.js/releases/tag/10.10.0 @muuki88 |
ChrisHuie
removed
not merged yet
Pending Prebid Module Release
5 participants
🏷 Type of documentation
📋 Checklist