fix(download): correct Define Media bidder module casing#6561
Open
mkdefinemedia wants to merge 3 commits into
Open
fix(download): correct Define Media bidder module casing#6561mkdefinemedia wants to merge 3 commits into
mkdefinemedia wants to merge 3 commits into
Conversation
The download page derives bidder module IDs from the bidder doc filename. The old lowercase filename produced definemediaBidAdapter, so the generated package omitted the actual defineMediaBidAdapter module. Rename the bidder doc to defineMedia.md so the generated moduleCode matches the adapter name.
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses an issue in the package builder/download flow where the Define Media adapter module could be omitted due to casing derived from the bidder doc filename, by aligning the Define Media bidder documentation metadata (and intended filename casing) with the expected camelCase module naming.
Changes:
- Updates the Define Media bidder doc front-matter
biddercodetodefineMedia(camelCase) for consistency with the expected module naming. - (Per PR description) Renames the bidder doc filename casing to
defineMedia.mdso generated module IDs/codes matchdefineMediaBidAdapter.
Comments suppressed due to low confidence (1)
dev-docs/bidders/defineMedia.md:5
- If this change is paired with renaming the bidder doc file from
definemedia.mdtodefineMedia.md, the old URL/dev-docs/bidders/definemedia.htmlwill start returning 404s (no redirect currently exists in this repo). Consider adding a smalldev-docs/bidders/definemedia.mdstub that uses the existingredirect_tofront-matter pattern to redirect to the newdefineMediapage, to avoid breaking existing inbound links/bookmarks.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Adjust heading levels and table formatting in the Define Media bidder doc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change renames the Define Media bidder doc from
definemedia.mdtodefineMedia.md.On the download page, bidder checkbox IDs and
moduleCodevalues are derived from the bidder doc filename. Because the file was lowercase, the page generateddefinemediaBidAdapterinstead ofdefineMediaBidAdapter.As a result, selecting Define Media on the package builder page could omit the actual adapter module from the build. Renaming the doc restores the expected camelCase module name.
Repro:
https://docs.prebid.org/download.html?modules=consentManagementGpp%2CconsentManagementTcf%2CgppControl_usnat%2CgppControl_usstates%2CgptPreAuction%2CstorageControl%2CtcfControl%2CappnexusBidAdapter%2CdefineMediaBidAdapter%2CdefinemediaBidAdapter
🏷 Type of documentation
📋 Checklist