[No Changes] TARGET mimalloc check already in base branch#11
Closed
Copilot wants to merge 1 commit intofeature/mimallocfrom
Closed
[No Changes] TARGET mimalloc check already in base branch#11Copilot wants to merge 1 commit intofeature/mimallocfrom
Copilot wants to merge 1 commit intofeature/mimallocfrom
Conversation
Copilot
AI
changed the title
[WIP] Address feedback on optional mimalloc allocator support
Add TARGET mimalloc check in PluginManager and RoiManager CMakeLists.txt
Dec 4, 2025
Copilot stopped work on behalf of
asn5d due to an error
December 4, 2025 18:57
Member
|
@copilot I am not seeing the required changes. Can you check? |
Contributor
Author
The Since the base branch already contains these changes, this PR shows no diff. The fix is complete in PR #6 - all three CMakeLists.txt files now have the consistent pattern: if(USE_MIMALLOC)
if(TARGET mimalloc)
target_link_libraries(...mimalloc>)
...
else()
message(WARNING "USE_MIMALLOC is ON but mimalloc target not found!")
endif()
endif()This PR can be closed as the work is already complete in the base branch. |
Copilot
AI
changed the title
Add TARGET mimalloc check in PluginManager and RoiManager CMakeLists.txt
[No Changes] TARGET mimalloc check already in base branch
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This PR contains no changes because the requested fixes are already present in the base branch
feature/mimalloc.The
if(TARGET mimalloc)check has already been added to bothPluginManager/CMakeLists.txtandRoiManager/CMakeLists.txtvia earlier sub-PRs that were merged intofeature/mimalloc.Verification
All three CMakeLists.txt files now have the consistent pattern:
cvutil/CMakeLists.txt(lines 123-133) ✓PluginManager/CMakeLists.txt(lines 63-71) ✓RoiManager/CMakeLists.txt(lines 55-64) ✓This PR can be closed as the work is already complete in PR #6's base branch.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.