fix: Dereference tags when building a snapshot - #223
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the BuildImages workflow to better handle git tag inputs when building snapshot images (dereferencing tags to the underlying commit), and improves multi-platform publish behavior by preserving existing platforms from an already-published manifest.
Changes:
- Initialize
typeearlier and dereference snapshot tag inputs to the commit SHA (tag^{commit}) when computing thefromreference. - Preserve existing platforms from the current registry manifest when publishing a multi-platform image.
- Update tests to cover the new dereference behavior and to account for the new existing-platforms lookup.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| firestarter/workflows/build_images/build_images.py | Dereference tags for snapshot builds; include existing manifest platforms; add manifest inspection helper. |
| firestarter/tests/test_build_images_functionality.py | Adjust dereference tests for snapshot vs release behavior; mock existing-platform lookup in compile/publish test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alambike
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/prefapp/features/issues/1126