fix: login to both snapshots and releases registries on build - #224
Open
jalvarezit wants to merge 3 commits into
Open
fix: login to both snapshots and releases registries on build#224jalvarezit wants to merge 3 commits into
jalvarezit wants to merge 3 commits into
Conversation
When building an image that uses a base image from the opposite registry (e.g. a releases image FROM a snapshots base image), the build would fail because Dagger was only authenticated in the registry matching the build type. Now both snapshots_registry and releases_registry are always logged into (when login_required is true and the registry is set), so cross-registry base image references work in both directions. Closes prefapp/features#1169
When building an image that uses a base image from the opposite registry (e.g. a releases image FROM a snapshots base image), the build would fail because Dagger was only authenticated in the registry matching the build type. Now both snapshots_registry and releases_registry are always logged into (when login_required is true and the registry is set), so cross-registry base image references work in both directions. Closes prefapp/features#1169
…p/firestarter-workflows into fix/login-both-registries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes https://github.com/prefapp/features/issues/1169