fix(ship): i18n ship-repo-section literal strings — unblock main CI#104
Merged
Conversation
ROA-264 (#100) added ship-repo-section.tsx with raw JSX strings that trip i18next/no-literal-string — 4 hard eslint errors that turned @multica/views#lint red on main, failing every CI run since the merge. - Reuse existing project_summary.{ready,blocked,draft}_pill keys (already have {{count}} interpolation in en + zh-Hans). - Add a repo_section block (expand/collapse aria-labels + empty state) to both locale files so the parity test stays green. - Wire useT("ship") + the selector-form t($ => ...) calls. Verification: - pnpm -F @multica/views run lint -> exit 0 (was: 4 errors) - pnpm -F @multica/views typecheck -> clean - @multica/views test -> 652/652 pass (incl. locale parity) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-authored-by: multica-agent <github@multica.ai>
c29d921 to
31f6a55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
mainCI has been red since #100 (ROA-264 ship-repo-sections) merged. Every CI run since fails at the@multica/views#lintstep:ship-repo-section.tsxshipped with raw JSX text + hard-codedaria-labelstrings that tripi18next/no-literal-string. Turbo stops the frontend pipeline at lint, so views typecheck/test never even run — the wholefrontendCI job is red.This is not from the upstream-sync PRs (#91/#92/#93). It's a gap in the ROA-264 feature merge; the sync PRs were green where they touched and are unrelated to this file.
Fix
project_summary.{ready,blocked,draft}_pillkeys (already have{{count}}interpolation in bothenandzh-Hans) for the count pills.repo_sectionblock (expand/collapsearia-labels +emptystate) to bothship.jsonlocale files solocales/parity.test.tsstays green.useT("ship")and the selector-formt(($) => $.…)calls, matching the pattern used across the other ship components.No behavioral change — same rendered text, now translatable.
Verification (local, on top of current
main)pnpm -F @multica/views run lint→ exit 0 (was: 4 errors)pnpm -F @multica/views typecheck→ cleanpnpm -F @multica/views test→ 652/652 pass (includeslocales/parity.test.ts,mention-suggestion.test.tsx,ship-release-page.test.tsx)🤖 Generated with Claude Code