fix(ship): i18n ship-repo-section badges — unblock main lint#106
Merged
Conversation
ROA-264 (PR #100, cf7fa29) merged with 4 i18next/no-literal-string ERRORS in ship-repo-section.tsx, turning @multica/views#lint red on main for ~12h and blocking the `frontend` CI check on every PR branched off f46918f (incl. #105). Wrap the unlocalized strings: - ready/blocked/draft count badges → reuse the existing project_summary.{ready,blocked,draft}_pill keys (already created for the sibling ship-project-section.tsx; no new keys needed). - "No pull requests" empty state → new project_summary.no_prs ("暂无 PR" in zh-Hans, matching the existing "暂无…" empty-state voice and the "PR" terminology used throughout the ship namespace). Mirrors the useT("ship") pattern already in ship-project-section.tsx. Verified: @multica/views lint 0 errors, views + web typecheck clean, both ship.json valid. Unblocks main and all pending PRs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unblocks
main. ROA-264 (PR #100,cf7fa29d) merged with 4i18next/no-literal-stringerrors inship-repo-section.tsx, turning@multica/views#lintred on main for ~12h. Every PR branched offf46918fc(including #105) fails thefrontendCI check on this inherited break.Fix
project_summary.{ready,blocked,draft}_pillkeys (already built for the siblingship-project-section.tsx; no new keys).project_summary.no_prs. zh-Hans:"暂无 PR"— matches the established"暂无…"empty-state voice (tooltip_no_prs: "暂无待处理 PR") and thePRterminology used throughout theshipnamespace.useT("ship")hook, mirroring the sibling component.Verification
@multica/views lint→ 0 errors (4 blocking errors gone; remaining 15 are pre-existing warnings, non-blocking)@multica/views+@multica/webtypecheck cleanship.jsonvalid JSONFollow-up (separate)
How did PR #100 merge with red CI? The merge-train apparently doesn't gate on the
frontendstatus check — that's the hole that let a main-breaking change land. Investigating next.🤖 Generated with Claude Code