This repository was archived by the owner on Jul 29, 2020. It is now read-only.
Open
Conversation
joelmdesouza
requested review from
avelino,
cassiobotaro,
crgimenes and
felipeweb
|
SourceLevel has finished reviewing this Pull Request and has found:
|
golangcibot
reviewed
Dec 1, 2019
| } | ||
| w.Header().Set("Content-Type", "text/plain") | ||
| w.WriteHeader(recorder.Code) | ||
| w.Write(result) |
There was a problem hiding this comment.
Error return value of w.Write is not checked (from errcheck)
avelino
suggested changes
Dec 1, 2019
| } | ||
| sort.Strings(keys) | ||
| var strOut bytes.Buffer | ||
| line := strings.Join(keys, ";") + "\n" |
Member
There was a problem hiding this comment.
You're writing csv on hand, there's the encoding/csv[1] package to do that job
| return strOut.Bytes(), nil | ||
| } | ||
|
|
||
| func decodeLine(keys []string, data map[string]interface{}) []string { |
Member
There was a problem hiding this comment.
encoding/csv does this job for you
https://golang.org/src/encoding/csv/writer.go#L48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: prest/prest#360