feat: add validation to prevent transmitting edocuments with mismatched invoice IDs#6
Merged
pritambiswal merged 1 commit intoprilk-consulting:developfrom Feb 4, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
If an invoice is submitted after its edocument is created, the source document reference may be updated but the XML content still contains the old draft invoice ID. This could result in transmitting incorrect invoice data.
Solution
Added comprehensive validation to
transmit_edocument()through a new_validate_edocument_for_transmission()function that verifies:docstatus == 1) for outgoing documentsIf validation fails, transmission is blocked with a clear error message instructing the user to regenerate the edocument.
Technical Details
_validate_edocument_for_transmission()functioncbc:ID) and CII (rsm:ExchangedDocument/ram:ID) formatsRelated