Merged
Conversation
0a01b2a to
0da7fbc
Compare
Webhook now detects Recommand notifications (eventType: document.received) and fetches actual XML from Recommand API using documentId. - Parse incoming data as JSON first - If Recommand notification, fetch XML via get_document_status API - Check for duplicates using EDocument.reference field - Fall back to raw XML for other providers (existing behavior)
0da7fbc to
4ed0106
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The webhook endpoint was treating all incoming data as raw XML. However, Recommand sends a
JSON notification when a document is received:
{
"eventType": "document.received",
"documentId": "doc_01KGC4QAPY9YWVRN03P9TAPV55",
"teamId": "team_01K8N25DE9T5A72FZMPJCBQQJH",
"companyId": "c_01K8N2P5YEMVJXSHRQQP60TSSE"
}
This notification was being saved as the XML content, instead of being used as a trigger to
fetch the actual document.
Solution
The webhook now:
behavior
Backward Compatibility