[ISSUE 17] implement drop_pii for arrays and maps#46
Draft
oxg558 wants to merge 13 commits into
Draft
Conversation
oxg558
force-pushed
the
issue-17-drop-pii-is-broken
branch
from
ecb1955 to
3813299
Compare
oxg558
force-pushed
the
issue-17-drop-pii-is-broken
branch
from
3813299 to
7edb635
Compare
oxg558
force-pushed
the
issue-17-drop-pii-is-broken
branch
from
4987730 to
5d2454f
Compare
oxg558
changed the title
and revert previous changes to the inspect_pii test file
oxg558
changed the title
oxg558
force-pushed
the
issue-17-drop-pii-is-broken
branch
from
eaab6fd to
2015180
Compare
oxg558
force-pushed
the
issue-17-drop-pii-is-broken
branch
from
434a08f to
abc9549
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17 by implementing
drop_piifor arrays and maps that have record values.Also adds a topological sort to the
generate_codefunction. This makes it easier to generate more complex schemas at runtime in tests like those written here fordrop_pii.