Avoid injecting nil in generated modules#47
Open
lpeppe wants to merge 1 commit into
Open
Conversation
when there are no pii fields
luca-tansini
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #45, records generated from schemas without any pii fields ended up with a stray
nilin the module body.The issue was in the
Inspectcode generation path: in the empty case,inspect_impl/1returned an empty quoted block, and unquoting that producesnil, which then got injected into the generated module. This change fixes it by returning an empty list instead and usingunquote_splicing, so nothing gets emitted when there is noInspectimpl to generate.When
piifields are present, the customInspectimplementation is still generated as before.