Skip to content

add pallas vs gpu test e2e#127

Open
pathfinder-pf wants to merge 1 commit intomainfrom
feat/add_pallas_gpu
Open

add pallas vs gpu test e2e#127
pathfinder-pf wants to merge 1 commit intomainfrom
feat/add_pallas_gpu

Conversation

@pathfinder-pf
Copy link
Copy Markdown
Collaborator

@pathfinder-pf pathfinder-pf commented Mar 31, 2026

Summary by CodeRabbit

  • Tests
    • Extended GPU test execution with additional coverage
    • Updated TPU test configuration to refine test scope

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 31, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f30f7396-4eec-446b-9a7a-e80f56002c07

📥 Commits

Reviewing files that changed from the base of the PR and between ad0d655 and 680b5ad.

📒 Files selected for processing (4)
  • .github/ci/gpu-tests.sky.yaml
  • .github/ci/tpu-tests-job.yaml
  • tests/ops/simple_gla/pallas_vs_gpu/test_chunk_simple_gla_bwd_gpu.py
  • tests/ops/simple_gla/pallas_vs_gpu/test_chunk_simple_gla_gpu.py

📝 Walkthrough

Walkthrough

Updates CI configuration to extend GPU test coverage by adding a new pytest invocation for tests/ops/simple_gla/pallas_vs_gpu/, while simultaneously excluding this test directory from TPU test execution to prevent duplication across test environments.

Changes

Cohort / File(s) Summary
CI Test Configuration
.github/ci/gpu-tests.sky.yaml
Adds new pytest invocation targeting tests/ops/simple_gla/pallas_vs_gpu/ with verbose output; removes trailing newline.
CI Test Configuration
.github/ci/tpu-tests-job.yaml
Adds tests/ops/simple_gla/pallas_vs_gpu/ to pytest exclusion list to prevent test execution on TPU runner.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐰 whiskers twitching with delight

GPU tests hop into the light,
While TPU tests step aside,
No duplication to confide!
CI pipelines running bright. 🚀

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'add pallas vs gpu test e2e' directly and specifically describes the main change: adding an end-to-end test for Pallas versus GPU comparison, which aligns with the GPU test execution step additions in the modified CI configuration files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/add_pallas_gpu

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces new GPU tests for simple_gla and updates the CI configuration to include these tests in the GPU suite while excluding them from the TPU suite. The review feedback highlights a necessary path adjustment in the test scripts to account for the new directory structure and suggests adding strict marker validation to the pytest command to maintain consistency with existing CI tasks.

-k triton \
-v
python -m pytest \
tests/ops/simple_gla/pallas_vs_gpu \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The tests in tests/ops/simple_gla/pallas_vs_gpu/ have a broken sys.path configuration due to the directory move. They currently use parents[3] to locate the repository root, but since they are now one level deeper, they should use parents[4]. This will cause import errors when running these tests directly as scripts.

Comment on lines +41 to +42
python -m pytest \
tests/ops/simple_gla/pallas_vs_gpu \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The new pytest command is missing the -o "addopts=--strict-markers" option used in the previous test execution (lines 36-40). Including this ensures that any custom markers used in the new tests are correctly validated, maintaining consistency across the CI suite.

  python -m pytest \
    -o "addopts=--strict-markers" \
    tests/ops/simple_gla/pallas_vs_gpu \

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant