Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughUpdates CI configuration to extend GPU test coverage by adding a new pytest invocation for Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Code Review
This pull request introduces new GPU tests for simple_gla and updates the CI configuration to include these tests in the GPU suite while excluding them from the TPU suite. The review feedback highlights a necessary path adjustment in the test scripts to account for the new directory structure and suggests adding strict marker validation to the pytest command to maintain consistency with existing CI tasks.
| -k triton \ | ||
| -v | ||
| python -m pytest \ | ||
| tests/ops/simple_gla/pallas_vs_gpu \ |
There was a problem hiding this comment.
The tests in tests/ops/simple_gla/pallas_vs_gpu/ have a broken sys.path configuration due to the directory move. They currently use parents[3] to locate the repository root, but since they are now one level deeper, they should use parents[4]. This will cause import errors when running these tests directly as scripts.
| python -m pytest \ | ||
| tests/ops/simple_gla/pallas_vs_gpu \ |
There was a problem hiding this comment.
The new pytest command is missing the -o "addopts=--strict-markers" option used in the previous test execution (lines 36-40). Including this ensures that any custom markers used in the new tests are correctly validated, maintaining consistency across the CI suite.
python -m pytest \
-o "addopts=--strict-markers" \
tests/ops/simple_gla/pallas_vs_gpu \
Summary by CodeRabbit