feat: publish design specs and plans as RFCs to primatrix/wiki#16
feat: publish design specs and plans as RFCs to primatrix/wiki#16sii-xinglong wants to merge 6 commits intomainfrom
Conversation
…rkflow Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on streamlining the design and implementation planning process by publishing design specifications and implementation plans as RFCs directly to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the process for handling design specs and implementation plans, moving from local markdown files to a centralized RFC process using a primatrix/wiki GitHub repository. The changes update several skill definitions to use the GitHub API for creating and updating RFCs. My review focuses on the correctness and robustness of the shell commands introduced for interacting with the GitHub API. I've identified several issues, including a brittle command for determining the next RFC number, incorrect usage of base64 encoding, and improper passing of the ref parameter for API calls which would cause them to fail or use the wrong branch. I've provided suggestions to fix these issues to ensure the new workflow is reliable.
plugins/superpowers/skills/brainstorming/spec-document-reviewer-prompt.md
Outdated
Show resolved
Hide resolved
plugins/superpowers/skills/subagent-driven-development/SKILL.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 17403890b4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
plugins/superpowers/skills/subagent-driven-development/SKILL.md
Outdated
Show resolved
Hide resolved
- Use `ref` as query parameter instead of HTTP header for Contents API - Use `printf | base64 -w 0` instead of `echo | base64` to avoid trailing newline and line wrapping - Make RFC number jq command handle empty `docs/rfc/` directory via `max // 0` fallback - Combine two API calls into one in writing-plans RFC fetch - Add `?ref=` and raw Accept header to all RFC content fetch examples Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary
primatrix/wikivia GitHub API instead of saving locally todocs/superpowers/specs/docs/superpowers/plans/New workflow
primatrix/wiki, associates with Project## Implementation Plansection to same RFC file on same branch/PRTest plan
docs/superpowers/specs/ordocs/superpowers/plans/in superpowers pluginprimatrix/wiki🤖 Generated with Claude Code