Skip to content

feat: publish design specs and plans as RFCs to primatrix/wiki#16

Open
sii-xinglong wants to merge 6 commits intomainfrom
feat/rfc-workflow-wiki
Open

feat: publish design specs and plans as RFCs to primatrix/wiki#16
sii-xinglong wants to merge 6 commits intomainfrom
feat/rfc-workflow-wiki

Conversation

@sii-xinglong
Copy link
Copy Markdown
Contributor

Summary

  • Modified brainstorming skill to publish design specs as RFCs to primatrix/wiki via GitHub API instead of saving locally to docs/superpowers/specs/
  • Modified writing-plans skill to append implementation plans to the same RFC file on the same PR branch instead of saving locally to docs/superpowers/plans/
  • Updated spec-document-reviewer-prompt, subagent-driven-development, and requesting-code-review skills to reference GitHub-hosted RFC files

New workflow

  1. brainstorming → determines next RFC number, asks user to select GitHub Project, creates branch + RFC file + PR in primatrix/wiki, associates with Project
  2. writing-plans → appends implementation plan as ## Implementation Plan section to same RFC file on same branch/PR
  3. execution → reads plan content from GitHub RFC file via API

Test plan

  • Verify YAML frontmatter validity in all modified SKILL.md files
  • Verify no remaining references to docs/superpowers/specs/ or docs/superpowers/plans/ in superpowers plugin
  • Run a brainstorming session end-to-end to confirm RFC is created correctly in primatrix/wiki
  • Run a writing-plans session to confirm plan is appended to existing RFC

🤖 Generated with Claude Code

sii-xinglong and others added 5 commits March 23, 2026 14:26
…rkflow

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on streamlining the design and implementation planning process by publishing design specifications and implementation plans as RFCs directly to the primatrix/wiki repository via the GitHub API. This change eliminates the need to store these documents locally and ensures that all relevant information is centralized and easily accessible. The updated workflow enhances collaboration and simplifies the review process.

Highlights

  • RFC Publication: The 'brainstorming' skill was modified to publish design specifications as RFCs to the primatrix/wiki using the GitHub API, instead of saving them locally.
  • Implementation Plan Appending: The 'writing-plans' skill was updated to append implementation plans to the same RFC file on the associated PR branch, rather than saving them locally.
  • Skill Updates: The 'spec-document-reviewer-prompt', 'subagent-driven-development', and 'requesting-code-review' skills were updated to reference the GitHub-hosted RFC files.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the process for handling design specs and implementation plans, moving from local markdown files to a centralized RFC process using a primatrix/wiki GitHub repository. The changes update several skill definitions to use the GitHub API for creating and updating RFCs. My review focuses on the correctness and robustness of the shell commands introduced for interacting with the GitHub API. I've identified several issues, including a brittle command for determining the next RFC number, incorrect usage of base64 encoding, and improper passing of the ref parameter for API calls which would cause them to fail or use the wrong branch. I've provided suggestions to fix these issues to ensure the new workflow is reliable.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 17403890b4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

- Use `ref` as query parameter instead of HTTP header for Contents API
- Use `printf | base64 -w 0` instead of `echo | base64` to avoid trailing newline and line wrapping
- Make RFC number jq command handle empty `docs/rfc/` directory via `max // 0` fallback
- Combine two API calls into one in writing-plans RFC fetch
- Add `?ref=` and raw Accept header to all RFC content fetch examples

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant