-
Notifications
You must be signed in to change notification settings - Fork 1
Enable expanded Biome lint rules #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
f68d5d9
enabled Biome and format
rtbenfield c2f76e8
biome recommended settings
rtbenfield 9f8dc0c
enable cognitive complexity lint rule
rtbenfield 94b1548
enable no foreach lint rule
rtbenfield d814e48
enable no implicit coercions lint rule
rtbenfield 36d2ff5
enable no conditional expect lint rule
rtbenfield b84856b
enable no floating promises lint rule
rtbenfield 7e202bf
enable no for in lint rule
rtbenfield 2100fd5
enable no loop func lint rule
rtbenfield 48f0d4c
enable disposable lint rule
rtbenfield ae87e2b
enable no await in loops lint rule
rtbenfield 8369f4c
enable no barrel file lint rule
rtbenfield 0be7bb9
enable top level regex lint rule
rtbenfield 5a61a24
enable collapsed else if lint rule
rtbenfield 63f3c08
enable collapsed if lint rule
rtbenfield 47516a7
enable no nested ternary lint rule
rtbenfield 5df9efb
enable no parameter assign lint rule
rtbenfield 621b41f
enable no var lint rule
rtbenfield 2d7f3c9
enable guarded for in lint rule
rtbenfield 0eec80d
enable static response methods lint rule
rtbenfield d6dac32
remove empty biome rule comments
rtbenfield aa69bbb
fix mask value regex backtracking
rtbenfield 5a35625
fix constructable test mocks
rtbenfield 53f61af
Add PR quality workflow
rtbenfield 2bd3a59
Set Node 22.12.0 as minimum version
rtbenfield 91c4f3f
address biome review feedback
rtbenfield 4c12f7e
trigger ci
rtbenfield efea28e
fix ci typecheck
rtbenfield File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # GitHub Workflows | ||
|
|
||
| - Pin all GitHub Actions to their commit SHA, not a tag. Append the tag as a comment for readability (e.g., `uses: actions/checkout@abc123... # v4.3.2`). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| name: PR Quality | ||
|
|
||
| # This workflow owns required PR status checks. Add only jobs that should block | ||
| # merging when they fail. | ||
|
|
||
| on: | ||
| pull_request: | ||
|
|
||
| concurrency: | ||
| group: pr-quality-${{ github.event.pull_request.number || github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| typecheck: | ||
| name: Type Check | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3 | ||
| with: | ||
| persist-credentials: false | ||
|
|
||
| - name: Set up pnpm | ||
| uses: pnpm/action-setup@0e279bb959325dab635dd2c09392533439d90093 # v6.0.8 | ||
|
|
||
| - name: Set up Node.js | ||
| uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0 | ||
| with: | ||
| node-version-file: .node-version | ||
| cache: pnpm | ||
|
|
||
| - name: Install dependencies | ||
| run: pnpm install --frozen-lockfile | ||
|
|
||
| - name: Type check | ||
| run: pnpm --recursive exec tsc --noEmit | ||
|
|
||
| lint: | ||
| name: Lint | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3 | ||
| with: | ||
| persist-credentials: false | ||
|
|
||
| - name: Set up Biome | ||
| uses: biomejs/setup-biome@4c91541eaada48f67d7dbd7833600ce162b68f51 # v2.7.1 | ||
|
|
||
| - name: Lint | ||
| run: biome ci . | ||
|
|
||
| test: | ||
| name: Test | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3 | ||
| with: | ||
| persist-credentials: false | ||
|
|
||
| - name: Set up pnpm | ||
| uses: pnpm/action-setup@0e279bb959325dab635dd2c09392533439d90093 # v6.0.8 | ||
|
|
||
| - name: Set up Node.js | ||
| uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0 | ||
| with: | ||
| node-version-file: .node-version | ||
| cache: pnpm | ||
|
|
||
| - name: Install dependencies | ||
| run: pnpm install --frozen-lockfile | ||
|
|
||
| - name: Test | ||
| run: pnpm --recursive test | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 22.12.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| { | ||
| "$schema": "https://biomejs.dev/schemas/2.4.16/schema.json", | ||
| "vcs": { | ||
| "enabled": true, | ||
| "clientKind": "git", | ||
| "useIgnoreFile": true | ||
| }, | ||
| "files": { | ||
| "ignoreUnknown": false | ||
| }, | ||
| "formatter": { | ||
| "enabled": true, | ||
| "indentStyle": "space", | ||
| "indentWidth": 2 | ||
| }, | ||
| "linter": { | ||
| "enabled": true, | ||
| "rules": { | ||
| "recommended": true, | ||
| "complexity": { | ||
| "noExcessiveCognitiveComplexity": "on", | ||
| "noForEach": "on", | ||
| "noImplicitCoercions": "on" | ||
| }, | ||
| "nursery": { | ||
| "noConditionalExpect": "on", | ||
| "noFloatingPromises": "on", | ||
| "noForIn": "on", | ||
| "noLoopFunc": "on", | ||
| "useDisposables": "on" | ||
| }, | ||
| "performance": { | ||
| "noAwaitInLoops": "on", | ||
| "noBarrelFile": "on", | ||
| "useTopLevelRegex": "on" | ||
| }, | ||
| "style": { | ||
| "useCollapsedElseIf": "on", | ||
| "useCollapsedIf": "on", | ||
| "noNestedTernary": "on", | ||
| "noParameterAssign": "on" | ||
| }, | ||
| "suspicious": { | ||
| "noVar": "on", | ||
| "useGuardForIn": "on", | ||
| "useStaticResponseMethods": "on" | ||
| } | ||
| } | ||
| }, | ||
| "javascript": { | ||
| "formatter": { | ||
| "quoteStyle": "double" | ||
| } | ||
| }, | ||
| "assist": { | ||
| "enabled": true, | ||
| "actions": { | ||
| "source": { | ||
| "organizeImports": "on" | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.