feat: add controlMinWidth to AppDimensions and update IntentButton minimum size for improved layout#497
Merged
feat: add controlMinWidth to AppDimensions and update IntentButton minimum size for improved layout#497
Conversation
- Implement tests for OTPToken, PushToken, SteamToken, and TOTPToken. - Validate static methods, serialization, and identity logic. - Ensure proper handling of edge cases and error scenarios. - Introduce MockToken class for testing purposes. - Cover scenarios for token creation, copying, and template updates.
- Implement tests for loading state from repository, retrieving tokens by ID, incrementing counters, removing tokens, and adding or replacing tokens. - Include tests for handling push tokens and QR code scanning for token enrollment. - Utilize mock repositories and utilities to simulate interactions and validate expected outcomes.
… rollover and sync buttons, and implement delete container dialogs - Deleted unused mock file for rollover_container_tokens_button_test. - Added unit tests for RolloverContainerTokensButton to check sync state behavior and visual alignment. - Introduced SyncContainerButton tests to validate button states and sync functionality. - Created DeleteContainerDialog tests to verify UI elements and logic for deleting containers. - Added ForceDeleteContainerDialog test to ensure delete action is called correctly.
…implement unit tests for delete functionality
- Removed unused imports and unnecessary code in dialog widgets. - Simplified button logic in DefaultDialog by integrating timed actions directly into IntentButton. - Cleaned up PushCodeToPhoneDialog by removing visibility handling and unnecessary state variables. - Updated PushDefaultDialog to remove redundant intent assignment. - Enhanced PushRequestDialog by removing unused imports. - Improved formatting and readability in various widget files, including DotIndicator, DragItemScroller, and home widget classes. - Refactored test cases for better clarity and consistency in token state tests.
…ved state management and UI responsiveness
…ity handling; enhance logging in ForceBiometricOption extension
- Removed direct usage of statusMessageProvider in favor of showErrorStatusMessage utility for better error handling in export tokens dialog and push request dialog. - Introduced StatusBar widget to manage status messages more effectively across settings view. - Updated IntentButton to support loading states and improved button behavior during sync operations. - Enhanced splash screen logic to ensure proper context checks. - Adjusted unit tests for sync container button to validate loading states and button behavior under different sync conditions. - Updated pubspec.lock and pubspec.yaml to include new dependencies and version adjustments.
…nimum size for improved layout
… checks in StatusMessage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.