Skip to content

Address PR #65 review comments: fix indentation, quote variables, document IPV6_ONLY#66

Merged
EdGeraghty merged 2 commits intov6_onlyfrom
copilot/sub-pr-65
Nov 26, 2025
Merged

Address PR #65 review comments: fix indentation, quote variables, document IPV6_ONLY#66
EdGeraghty merged 2 commits intov6_onlyfrom
copilot/sub-pr-65

Conversation

Copy link

Copilot AI commented Nov 26, 2025

Applies the bot review comments from PR #65 to fix shell script formatting and documentation issues.

Changes

  • scripts/container-entrypoint.sh:211 — Replace tabs with spaces in template_vars array for consistent indentation
  • scripts/container-entrypoint.sh:173-176 — Quote variable expansions (${IPV4_PREFIX}, ${IPV6_PREFIX}) to prevent word splitting
  • templates/secrets.template.env:27-28 — Document IPV6_ONLY environment variable alongside existing IP prefix configuration
# Before
export IP_PREFIXES="v6: $IPV6_PREFIX"

# After  
export IP_PREFIXES="v6: ${IPV6_PREFIX}"

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: EdGeraghty <20861699+EdGeraghty@users.noreply.github.com>
Copilot AI changed the title [WIP] Add IPv6-only mode, defaulted off Address PR #65 review comments: fix indentation, quote variables, document IPV6_ONLY Nov 26, 2025
Copilot AI requested a review from EdGeraghty November 26, 2025 11:36
@EdGeraghty EdGeraghty marked this pull request as ready for review November 26, 2025 11:37
@EdGeraghty EdGeraghty merged commit c17ad37 into v6_only Nov 26, 2025
2 checks passed
@EdGeraghty EdGeraghty deleted the copilot/sub-pr-65 branch November 26, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants