Make ephemeral_node_inactivity_timeout a var#67
Merged
EdGeraghty merged 3 commits intodevelopfrom Dec 12, 2025
Merged
Conversation
Keep a default of 30m, allow changes through an environment var
🆕 New Headscale Config Options+ v4
+ v6``` |
There was a problem hiding this comment.
Pull request overview
This pull request makes the ephemeral node inactivity timeout configurable through an environment variable whilst maintaining backward compatibility with a 30-minute default. The change enables runtime configuration of the timeout without modifying template files.
- Added
EPHEMERAL_NODE_INACTIVITY_TIMEOUTenvironment variable support with a default value - Integrated the new variable into the configuration pipeline and display summary
- Updated the Headscale template to use the environment variable for timeout configuration
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
templates/headscale.template.yaml |
Replaced hardcoded 30m timeout with environment variable substitution |
scripts/defaults.sh |
Added default value definition for the timeout (30m) following project naming conventions |
scripts/container-entrypoint.sh |
Added environment variable validation, export handling, and configuration summary display |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This comment was marked as duplicate.
This comment was marked as duplicate.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
🆕 New Headscale Config Options+ v4
+ v6``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep a default of 30m, allow changes through an environment var
This pull request introduces support for configuring the ephemeral node inactivity timeout via an environment variable, improving flexibility and consistency in the container setup. The changes ensure that the timeout value can be set using
EPHEMERAL_NODE_INACTIVITY_TIMEOUT, with a sensible default and visibility in configuration summaries.Ephemeral Node Inactivity Timeout Configuration:
headscale_ephemeral_node_inactivity_timeout_default("30m") inscripts/defaults.shto ensure a baseline timeout is set if not provided.check_headscale_environment_varsfunction inscripts/container-entrypoint.shto check or set theEPHEMERAL_NODE_INACTIVITY_TIMEOUTenvironment variable.EPHEMERAL_NODE_INACTIVITY_TIMEOUTin the list of template variables exported for configuration generation inscripts/container-entrypoint.sh.templates/headscale.template.yaml) to use theEPHEMERAL_NODE_INACTIVITY_TIMEOUTenvironment variable for theephemeral_node_inactivity_timeoutsetting.Configuration Visibility:
EPHEMERAL_NODE_INACTIVITY_TIMEOUTfor easier verification and debugging.