Conversation
This is a fork focussed on i18n, but has bug fixes for new logic paths. Unless upstream resurrects the project, the current admin panel is deprecated and planned to be replaced before headscale `0.29.X`
This comment was marked as outdated.
This comment was marked as outdated.
🆕 New Headscale Config Options+ taildrop
+ v4
+ v6``` |
There was a problem hiding this comment.
Pull request overview
This pull request migrates the Headscale-Admin GUI from using a deprecated pre-built Docker image to building from source using a community fork (serein-213/headscale-admin-il18n). The change addresses the upstream project's abandonment but introduces several critical security and build reliability concerns.
Changes:
- Switched from pre-built
goodieshq/headscale-admin:0.26.0image to building from source using a forked repository - Updated documentation to reflect the new fork and added deprecation warning about future replacement
- Modified Dockerfile to include Node.js build stage with npm build process
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| README.md | Updated version table and links to point to new fork; added deprecation notice warning of future replacement |
| Dockerfile | Replaced pre-built image with multi-stage build from source; added new ARG variables for repo URL, branch, and Node version; implemented git clone and npm build process |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Not really needed as this layer is discarded anyway, but may as well clean up as we go
🆕 New Headscale Config Options+ taildrop
+ v4
+ v6``` |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| WORKDIR /app | ||
|
|
||
| ENV ENDPOINT="${HEADSCALE_ADMIN_ENDPOINT}" | ||
| RUN npm install && npm run build; |
There was a problem hiding this comment.
Using 'npm install' without '--production' or 'npm ci' may install development dependencies unnecessarily, increasing image size and attack surface. For Docker builds, 'npm ci --production' is preferred as it ensures reproducible builds and only installs production dependencies.
| RUN npm install && npm run build; | |
| RUN npm ci --omit=dev && npm run build; |
| RUN git clone ${HEADSCALE_ADMIN_REPO} /app && \ | ||
| cd /app && \ | ||
| git checkout ${HEADSCALE_ADMIN_VERSION} |
There was a problem hiding this comment.
The git clone operation does not verify commit signatures or repository authenticity. Consider adding 'git config --global transfer.fsckObjects true' before cloning to enable additional safety checks, especially since you're building from an untagged commit from a third-party repository.
🆕 New Headscale Config Options+ v4
+ v6``` |
This pull request transitions the Headscale Admin GUI from using a prebuilt Docker image to building from source using a maintained fork (serein-213/headscale-admin-il18n), addresses the deprecation of the original GoodiesHQ/headscale-admin project, and upgrades Headscale from v0.27.1 to v0.28.0. The changes enable continued compatibility with newer Headscale releases whilst the project evaluates long-term admin panel alternatives.
Changes: