Hopefully a fix for "Modulation Range Error #562"#565
Draft
dcoredump wants to merge 22 commits intoprobonopd:mainfrom
Draft
Hopefully a fix for "Modulation Range Error #562"#565dcoredump wants to merge 22 commits intoprobonopd:mainfrom
dcoredump wants to merge 22 commits intoprobonopd:mainfrom
Conversation
Fix for SYSEX MIDI dump output.
Disabled printing of MIDI data in incoming serial data. Added some mor debug output.
Fix for using MIDI channel for SYSEX.
Adding master volume and changing master volume when SYSEX master volume is triggered.
…ater for other parameters).
…e range or target of controllers, due to problems.
Owner
|
Thanks @dcoredump. Unfortunately something is still wrong according to the test in #562 (comment), so I am not merging this yet. |
Owner
|
Hello @dcoredump. You suspect the issue might be in MiniDexed, do you have a suspicion where we should look? Thanks. |
|
Build for testing: |
Contributor
Author
I think it must be MiniDexed because MicroDexed has no problems. This is the place where the modwheel code is used in MicroDexed. I am currently very short of time and cannot look into MiniDexed code - sorry. Hope this helps, Holger |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I currently have no keyboard right here, so I cannot check the difference between MiniDexed and MicroDexed, sorry. But looking at the code I saw that I removed the calls to
ControllersRefresh()when changing the range or target of the controllers in MicroDexed. So I made comments for these calls in MiniDexed, hopefully the problems are fixed.