Terminate the program when the maximum ping difference is exceeded#292
Open
yjoer wants to merge 5 commits intoprobot:masterfrom
Open
Terminate the program when the maximum ping difference is exceeded#292yjoer wants to merge 5 commits intoprobot:masterfrom
yjoer wants to merge 5 commits intoprobot:masterfrom
Conversation
zebabakhteyar
approved these changes
Feb 11, 2025
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Collaborator
|
why dont we call it timeout? or pingTimeout? |
Contributor
|
sounds good to me, i only updated it to fix the merge conflicts, and some slight updates to use private fields |
Graysonbarton
approved these changes
Jul 15, 2025
Graysonbarton
left a comment
Graysonbarton
left a comment
There was a problem hiding this comment.
Signed-off-by: Grayson Barton gveyron18@outlook.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by #179, I added an option to enable health checks to terminate the program if a ping is not received within a specified period. In container orchestration systems like Docker/Kubernetes, a container can be restarted once the process within is terminated. For this reason, the changes do not include the capability to restart the connection while leaving the process intact. Apart from the scenario mentioned in #179, this seems needed for networks behind a CGNAT where the ISP might assign a different IP address to a user anytime.