fix: resolve visualID render crash in Sketch component#1201
Closed
priyaa-j wants to merge 1 commit intoprocessing:mainfrom
Closed
fix: resolve visualID render crash in Sketch component#1201priyaa-j wants to merge 1 commit intoprocessing:mainfrom
priyaa-j wants to merge 1 commit intoprocessing:mainfrom
Conversation
Member
|
Closing for now, upstream bug was resolved - see linked issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1191
Description:
This PR adds a guard clause in
Sketch.astro. Currently, when the OpenProcessing API fails (like a 403 or 500 error), the item variable becomes undefined, and the code tries to accessitem.visualID, which causes aTypeErrorand crashes the entire page.Changes:
The fix adds a simple check at the top:
if (!item) returnThis means if item is undefined or null, the component stops rendering immediately and never tries to accessitem.visualIDso the page loads safely without crashing.Verification:
The issue was already happening when the API failed when I run the server locally.
Without fix: API fails →
itemundefined → page crashes ❌With fix: API fails → guard clause stops execution → page loads safely ✅
Tested locally on real API failure. Works perfectly.