Aria labels pr#909
Closed
eslteacher902010 wants to merge 6 commits intoprocessing:mainfrom
Closed
Conversation
Member
|
Closing this one as the cleaned up version is merged #910 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
This PR is a clean version of PR #894, with just the accessibility-related commits included.
It adds ARIA labels and other accessibility improvements to navigation components (MainNavLinks and JumpToLinks), and also includes a small JSX indentation fix---the contrast change was left out as requested.
Thanks again for the guidance on how to clean this up — and sorry about the hassle. I believe all conflicts have been resolved, and everything should be good to go but please let me know.