Focus accessibility problem for screen reader and keyboard#916
Focus accessibility problem for screen reader and keyboard#916AshmitSherigar wants to merge 2 commits intoprocessing:mainfrom AshmitSherigar:fix-focus
Conversation
|
@coseeian Could you also review this PR too thanks alot |
|
I’ve tested the updated focus behavior in this PR, and everything works as expected. I think it’s OK. |
|
Thank you |
|
@coseeian could u see this code |
ksen0
left a comment
There was a problem hiding this comment.
Hi @AshmitSherigar , thank you for your work on this and sorry for the delay.
The PR contains many small changes not related to the issue (removing comments, changing if statements, removing {}), so please revert all changes that are not necessary. Functionally it works, but it is difficult to understand what has changed and verify that there are no side effects. Please edit this PR so it is more clear what has been changed. Thank you very much!
I realize it's been a little while, so if you don't respond in the next 7 days, I can go ahead and add a commit to clean it up so it can be merged.
|
|
||
| const clearInput = () => { | ||
| if (inputRef.current) inputRef.current.value = ""; | ||
| setInputEdited(false); |
There was a problem hiding this comment.
Are the main changes of this PR the addition of this line and the line below? Or something else as well?
|
@ksen0 let me look into this now give me some time |
|
@ksen0 i will make a new PR since i lost the track of this .. is it fine? |
|
@AshmitSherigar Yes, that's no problem, you can close this and open another one. |
What I Fixed
How to Test
Files Changed
Let me know if there is any update for me to do
Closes #914