-
Notifications
You must be signed in to change notification settings - Fork 20
Baramon Lares #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Barrylares
wants to merge
1
commit into
profstein:master
Choose a base branch
from
Barrylares:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| <!DOCTYPE html> | ||
| <html> | ||
| <head> | ||
| <meta charset="utf-8"> | ||
| <title>Assignment 1: Q-A in HTML </title> | ||
| </head> | ||
| <body> | ||
| <h1>Assignment 1: Q-A in HTML</h1> | ||
| <h2>Baramon Lares</h2> | ||
|
|
||
|
|
||
|
|
||
| <ol> <li>Do you consider yourself more of a designer or developer (or something else, other answers are acceptable)? | ||
| <ul><li> I consider myself more of a designer transitioning into the technical aspect of<strong> UI/UX Design</strong></li></ul></li> | ||
|
|
||
| <li>What are you most interested in learning in this class? | ||
| <ul><li> I am most interested in learning Responsive Web Design and Modern Web Design</li></ul></li> | ||
|
|
||
| <li>What is good design? | ||
| <ul><li> To me good design is being able to communicate with the user in a simplistic enjoyable form that's entertaining to the eye. </li></ul></li> | ||
|
|
||
| <li> What is good web design? | ||
|
|
||
| <ul><li><strong>Good Web Design </strong>isn't about fancy colors and artwork. Good design is being able represent what your trying to communicate to the user that matches the content using less elements with more meaning</li></ul></li> | ||
|
|
||
| <li> What are the good examples of conference/event web sites? Answer by listing at least two sites including each URL and why you chose the site. | ||
|
|
||
| <br><ul><li> Here are some great examples of websites here. (For which I am a <em>huge fan</em> of <strong>Flat Web Design)</strong> </li></ul> | ||
| <p><a href="http://www.psd2html.com/"> PSD2HTML </a> and <a href="http://www.nextr.info/"> Nextr.info</a></p> </li> | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These are both fine web sites. But the only problem is that neither of them are for conference or event sites. Since we are dealing with an event web site in class I want you to find some similar sites from which you might draw inspiration and examples. |
||
|
|
||
| </ol> | ||
| </body> | ||
| </html> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| <!DOCTYPE html> | ||
| <html> | ||
| <head> | ||
| <meta charset="utf-8"> | ||
| <title>Assignment 1: Q-A in HTML </title> | ||
| </head> | ||
| <body> | ||
| <h1>Assignment 1: Q-A in HTML</h1> | ||
| <h2>Baramon Lares</h2> | ||
| <ol> <li>Do you consider yourself more of a designer or developer (or something else, other answers are acceptable)?</li></ol> | ||
| <ul><li> I consider myself more of a designer transitioning into the technical aspect of<strong> UI/UX Design</strong></li></ul> | ||
|
|
||
| <ol><li>What are you most interested in learning in this class?</li></ol> | ||
| <ul><li> I am most interested in learning Responsive Web Design and Modern Web Design</li></ul> | ||
|
|
||
| <ol><li>What is good design?</li></ol> | ||
| <ul><li> To me good design is being able to communicate with the user in a simplistic enjoyable form that's entertaining to the eye. </li></ul> | ||
|
|
||
| <ol><li> What is good web design?</li></ol> | ||
|
|
||
| <ul><li><strong>Good Web Design </strong>isn't about fancy colors and artwork. Good design is being able represent what your trying to communicate to the user that matches the content using less elements with more meaning</li></ul> | ||
|
|
||
| <ol> <li> What are the good examples of conference/event web sites? Answer by listing at least two sites including each URL and why you chose the site.</li></ol> | ||
|
|
||
| <br><ul><li> Here are some great examples of websites here. (For which I am a <em>huge fan</em> of <strong>Flat Web Design)</strong> </li> </ul> | ||
| <p><a href="http://www.psd2html.com/"> PSD2HTML </a> and <a href="http://www.nextr.info/"> Nextr.info</a> </p> | ||
|
|
||
| </body> | ||
| </html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| <!DOCTYPE html> | ||
| <html> | ||
| <head> | ||
| <meta charset="utf-8"> | ||
| <title>Assignment 1: Q-A in HTML </title> | ||
| </head> | ||
| <body> | ||
| <h1>Assignment 1: Q-A in HTML</h1> | ||
| <h2>Baramon Lares</h2> | ||
|
|
||
|
|
||
|
|
||
| <ol> <li>Do you consider yourself more of a designer or developer (or something else, other answers are acceptable)? | ||
| <ul><li> I consider myself more of a designer transitioning into the technical aspect of<strong> UI/UX Design</strong></li></ul></li> | ||
|
|
||
| <li>What are you most interested in learning in this class? | ||
| <ul><li> I am most interested in learning Responsive Web Design and Modern Web Design</li></ul></li> | ||
|
|
||
| <li>What is good design? | ||
| <ul><li> To me good design is being able to communicate with the user in a simplistic enjoyable form that's entertaining to the eye. </li></ul></li> | ||
|
|
||
| <li> What is good web design? | ||
|
|
||
| <ul><li><strong>Good Web Design </strong>isn't about fancy colors and artwork. Good design is being able represent what your trying to communicate to the user that matches the content using less elements with more meaning</li></ul></li> | ||
|
|
||
| <li> What are the good examples of conference/event web sites? Answer by listing at least two sites including each URL and why you chose the site. | ||
|
|
||
| <br><ul><li> Here are some great examples of websites here. (For which I am a <em>huge fan</em> of <strong>Flat Web Design)</strong> </li></ul> | ||
| <p><a href="http://www.psd2html.com/"> PSD2HTML </a> and <a href="http://www.nextr.info/"> Nextr.info</a></p> </li> | ||
|
|
||
| </ol> | ||
| </body> | ||
| </html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| <!DOCTYPE html> | ||
| <html> | ||
| <head> | ||
| <title>Barry Cloud 9 Project </title> | ||
| </head> | ||
| <body> | ||
|
|
||
| </body> | ||
| </html> | ||
| <!-- uploading. $ git add . , then $git commit -m , $ push |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| <!DOCTYPE html> | ||
| <html> | ||
| <head> | ||
| <title> Im here</title> | ||
| </head> | ||
| <body> | ||
|
|
||
| </body> | ||
| </html> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting choice to put lists within lists. In this case it may be more complex than you need.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When i researched it was the only way to have an
tag inside of an
. The solution I found was to have them within an- which was allowed. Thanks for the feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't get a chance to make my comment more complete.
Yes, you are correct that to have a list within a list the inner list has to be inside of the
html <li> </li>elements. And you did add them in correctly.What I would like you to rethink is which elements you use. You really want to accomplish a few things with the markup:
I should say up front that there is no perfect answer for how to mark up this assignment — see this discussion. There is no Q&A element in HTML5. So I'm more looking that you have made an effort to do the three things above.
If you want to keep them in a list one way would be to use a definition list, sitepoint reference
and so on. This fultills one and two pretty well (ideally you would have a class or id on the dl ), but it's a bit questionable on 3 as to whether this is the best semantically.
Another alternative is to use something like headings for questions and paragraphs for answers
The problem here is that you don't have any thing for 1 (show the two are a pair). You could add
<div></div>tags around each pair to do that. It would create more markup though and semantics is again questionable. For that I would say it depends on how involved the questions and answers are. You can also add a class to all of the answer p's to help distinguish them from other paragraphs on the page and make styling and separation of the pairs easier.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review, and your definitely right. Mentally I didn't create it for mark-up but yes adding divs and classes will give me more control over them all.