Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions docs/VULNERABILITY_CATALOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@ from each file's header comment, so this page cannot drift from the source.

## Totals

- **Test cases:** 62
- **Expected detections:** 62
- **`VULNERABLE:` markers:** 123 (individual lines a scanner should flag)
- **`SAFE:` markers:** 73 (lines a scanner must not flag — the false-positive control group)
- **Test cases:** 63
- **Expected detections:** 63
- **`VULNERABLE:` markers:** 124 (individual lines a scanner should flag)
- **`SAFE:` markers:** 74 (lines a scanner must not flag — the false-positive control group)
- **Languages:** 8 — dotenv, go, java, javascript, json, python, ruby, text
- **CWE categories:** 46 — CWE-20, CWE-22, CWE-78, CWE-79, CWE-89, CWE-90, CWE-95, CWE-113, CWE-117, CWE-190, CWE-201, CWE-209, CWE-256, CWE-295, CWE-321, CWE-327, CWE-330, CWE-338, CWE-346, CWE-347, CWE-352, CWE-362, CWE-377, CWE-384, CWE-489, CWE-502, CWE-506, CWE-532, CWE-601, CWE-611, CWE-614, CWE-639, CWE-643, CWE-681, CWE-759, CWE-798, CWE-862, CWE-915, CWE-918, CWE-942, CWE-943, CWE-1236, CWE-1321, CWE-1333, CWE-1336, CWE-1357
- **CWE categories:** 47 — CWE-20, CWE-22, CWE-78, CWE-79, CWE-89, CWE-90, CWE-95, CWE-113, CWE-117, CWE-190, CWE-201, CWE-209, CWE-256, CWE-269, CWE-295, CWE-321, CWE-327, CWE-330, CWE-338, CWE-346, CWE-347, CWE-352, CWE-362, CWE-377, CWE-384, CWE-489, CWE-502, CWE-506, CWE-532, CWE-601, CWE-611, CWE-614, CWE-639, CWE-643, CWE-681, CWE-759, CWE-798, CWE-862, CWE-915, CWE-918, CWE-942, CWE-943, CWE-1236, CWE-1321, CWE-1333, CWE-1336, CWE-1357

## How coverage is scored

Expand All @@ -36,6 +36,7 @@ counts as a detection. See `docs/SCANNER_INTEGRATION.md`.
| Test case | File | CWE | Severity | Expected | Markers |
|---|---|---|---|---|---|
| Insecure deserialisation via ObjectInputStream | [`deserialization-object-input-stream.java`](../vulns/java/deserialization-object-input-stream.java) | CWE-502 | critical | yes | 2 vuln / 2 safe |
| Insecure permission check via user-controlled role parameter | [`cwe-269-java.java`](../vulns/java/cwe-269-java.java) | CWE-269 | high | yes | 1 vuln / 1 safe |
| SQL injection via Statement string concatenation | [`sqli-statement-concat.java`](../vulns/java/sqli-statement-concat.java) | CWE-89 | critical | yes | 2 vuln / 1 safe |
| Reflected XSS via HttpServletResponse writer | [`xss-response-writer.java`](../vulns/java/xss-response-writer.java) | CWE-79 | high | yes | 2 vuln / 2 safe |
| XXE via unconfigured DocumentBuilderFactory | [`xxe-document-builder.java`](../vulns/java/xxe-document-builder.java) | CWE-611 | high | yes | 2 vuln / 1 safe |
Expand Down
32 changes: 28 additions & 4 deletions vulns/VULNERABILITY_CATALOG.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
"schema": "threatcrush-testbed-catalog/1",
"note": "Generated by scripts/generate-catalog.py \u2014 do not edit by hand.",
"totals": {
"test_cases": 62,
"expected_detections": 62,
"vulnerable_markers": 123,
"safe_markers": 73,
"test_cases": 63,
"expected_detections": 63,
"vulnerable_markers": 124,
"safe_markers": 74,
"languages": [
"dotenv",
"go",
Expand Down Expand Up @@ -39,6 +39,7 @@
"CWE-201",
"CWE-209",
"CWE-256",
"CWE-269",
"CWE-295",
"CWE-321",
"CWE-327",
Expand Down Expand Up @@ -175,6 +176,29 @@
56
]
},
{
"id": "java-insecure-permission-check",
"file": "vulns/java/cwe-269-java.java",
"title": "Insecure permission check via user-controlled role parameter",
"category": "java",
"language": "java",
"cwe": "CWE-269",
"cwes": [
"CWE-269"
],
"severity": "high",
"expected_detection": true,
"description": "A user-controlled role parameter from an HTTP request is used",
"detection_target": "User-controlled role parameter used in authorization check",
"safe_guard": "Every payload is behind the always-false NEVER_RUN constant and",
"attribution": "line",
"vulnerable_lines": [
33
],
"safe_lines": [
47
]
},
{
"id": "java-deserialization-object-input-stream",
"file": "vulns/java/deserialization-object-input-stream.java",
Expand Down
53 changes: 53 additions & 0 deletions vulns/java/cwe-269-java.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
/**
* @id java-insecure-permission-check
* @test-case Insecure permission check via user-controlled role parameter
* @cwe CWE-269
* @severity high
* @language java
* @expected-detection true
* @description A user-controlled role parameter from an HTTP request is used
* directly in an authorization check without proper validation or
* normalization. An attacker can manipulate the role parameter to
* escalate privileges and access restricted resources. This
* violates the principle of least privilege and enables improper
* privilege management.
* @safe-guard Every payload is behind the always-false NEVER_RUN constant and
* the repository has no Java build file, so nothing is compiled. No
* real credentials or sensitive data are included in this file.
* @detection-target User-controlled role parameter used in authorization check
* without validation or normalization.
*
* NEVER RUN IN PRODUCTION — intentional test case for scanner validation.
*/
package vulns.java;

import javax.servlet.http.HttpServletRequest;

public class InsecurePermissionCheck {

private static final boolean NEVER_RUN = false;

public boolean checkAccessVulnerable(HttpServletRequest req) {
if (NEVER_RUN) {
String role = req.getParameter("role"); // SOURCE: user-controlled
// VULNERABLE: CWE-269 - role parameter used directly in authorization
return "admin".equals(role);
}
return false;
}

/**
* Safe counterpart — the scanner should NOT flag this.
*
* @expected-detection false
*/
public boolean checkAccessSafe(HttpServletRequest req) {
if (NEVER_RUN) {
String role = req.getParameter("role");
// SAFE: role is validated against a server-side session attribute
String sessionRole = (String) req.getSession().getAttribute("role");
return "admin".equals(sessionRole) && "admin".equals(role);
}
return false;
}
}
Loading