test-cases: add CWE-302 (java)

docs/VULNERABILITY_CATALOG.md

@@ -7,12 +7,12 @@ from each file's header comment, so this page cannot drift from the source.
 
 ## Totals
 
-- **Test cases:** 62
-- **Expected detections:** 62
-- **`VULNERABLE:` markers:** 123 (individual lines a scanner should flag)
-- **`SAFE:` markers:** 73 (lines a scanner must not flag — the false-positive control group)
+- **Test cases:** 63
+- **Expected detections:** 63
+- **`VULNERABLE:` markers:** 124 (individual lines a scanner should flag)
+- **`SAFE:` markers:** 74 (lines a scanner must not flag — the false-positive control group)
 - **Languages:** 8 — dotenv, go, java, javascript, json, python, ruby, text
-- **CWE categories:** 46 — CWE-20, CWE-22, CWE-78, CWE-79, CWE-89, CWE-90, CWE-95, CWE-113, CWE-117, CWE-190, CWE-201, CWE-209, CWE-256, CWE-295, CWE-321, CWE-327, CWE-330, CWE-338, CWE-346, CWE-347, CWE-352, CWE-362, CWE-377, CWE-384, CWE-489, CWE-502, CWE-506, CWE-532, CWE-601, CWE-611, CWE-614, CWE-639, CWE-643, CWE-681, CWE-759, CWE-798, CWE-862, CWE-915, CWE-918, CWE-942, CWE-943, CWE-1236, CWE-1321, CWE-1333, CWE-1336, CWE-1357
+- **CWE categories:** 47 — CWE-20, CWE-22, CWE-78, CWE-79, CWE-89, CWE-90, CWE-95, CWE-113, CWE-117, CWE-190, CWE-201, CWE-209, CWE-256, CWE-295, CWE-302, CWE-321, CWE-327, CWE-330, CWE-338, CWE-346, CWE-347, CWE-352, CWE-362, CWE-377, CWE-384, CWE-489, CWE-502, CWE-506, CWE-532, CWE-601, CWE-611, CWE-614, CWE-639, CWE-643, CWE-681, CWE-759, CWE-798, CWE-862, CWE-915, CWE-918, CWE-942, CWE-943, CWE-1236, CWE-1321, CWE-1333, CWE-1336, CWE-1357
 
 ## How coverage is scored
 
@@ -35,6 +35,7 @@ counts as a detection. See `docs/SCANNER_INTEGRATION.md`.
 
 | Test case | File | CWE | Severity | Expected | Markers |
 |---|---|---|---|---|---|
+| Authentication bypass via user-controlled session identifier | [`cwe-302-java.java`](../vulns/java/cwe-302-java.java) | CWE-302 | critical | yes | 1 vuln / 1 safe |
 | Insecure deserialisation via ObjectInputStream | [`deserialization-object-input-stream.java`](../vulns/java/deserialization-object-input-stream.java) | CWE-502 | critical | yes | 2 vuln / 2 safe |
 | SQL injection via Statement string concatenation | [`sqli-statement-concat.java`](../vulns/java/sqli-statement-concat.java) | CWE-89 | critical | yes | 2 vuln / 1 safe |
 | Reflected XSS via HttpServletResponse writer | [`xss-response-writer.java`](../vulns/java/xss-response-writer.java) | CWE-79 | high | yes | 2 vuln / 2 safe |

vulns/VULNERABILITY_CATALOG.json

@@ -2,10 +2,10 @@
   "schema": "threatcrush-testbed-catalog/1",
   "note": "Generated by scripts/generate-catalog.py \u2014 do not edit by hand.",
   "totals": {
-    "test_cases": 62,
-    "expected_detections": 62,
-    "vulnerable_markers": 123,
-    "safe_markers": 73,
+    "test_cases": 63,
+    "expected_detections": 63,
+    "vulnerable_markers": 124,
+    "safe_markers": 74,
     "languages": [
       "dotenv",
       "go",
@@ -40,6 +40,7 @@
       "CWE-209",
       "CWE-256",
       "CWE-295",
+      "CWE-302",
       "CWE-321",
       "CWE-327",
       "CWE-330",
@@ -175,6 +176,29 @@
         56
       ]
     },
+    {
+      "id": "java-authentication-bypass-weak-session-identifier",
+      "file": "vulns/java/cwe-302-java.java",
+      "title": "Authentication bypass via user-controlled session identifier",
+      "category": "java",
+      "language": "java",
+      "cwe": "CWE-302",
+      "cwes": [
+        "CWE-302"
+      ],
+      "severity": "critical",
+      "expected_detection": true,
+      "description": "The application trusts a session identifier supplied directly",
+      "detection_target": "Session identifier taken from user input without server-side",
+      "safe_guard": "Every payload is behind the always-false NEVER_RUN constant and",
+      "attribution": "line",
+      "vulnerable_lines": [
+        37
+      ],
+      "safe_lines": [
+        54
+      ]
+    },
     {
       "id": "java-deserialization-object-input-stream",
       "file": "vulns/java/deserialization-object-input-stream.java",

vulns/java/cwe-302-java.java

@@ -0,0 +1,60 @@
+/**
+ * @id java-authentication-bypass-weak-session-identifier
+ * @test-case Authentication bypass via user-controlled session identifier
+ * @cwe CWE-302
+ * @severity critical
+ * @language java
+ * @expected-detection true
+ * @description The application trusts a session identifier supplied directly
+ *              by the client (e.g., via a request parameter or header) without
+ *              validating it against server-side session storage. An attacker
+ *              can set the identifier to a known or guessed value, bypassing
+ *              authentication and gaining access to another user's session.
+ *              This is a classic CWE-302 (Authentication Bypass by Assumed-
+ *              Immutable Data) scenario where client-controlled data is
+ *              assumed to be trustworthy and immutable.
+ * @safe-guard Every payload is behind the always-false NEVER_RUN constant and
+ *             the repository has no Java build file, so nothing is compiled.
+ *             No real session data or credentials are included in this file.
+ * @detection-target Session identifier taken from user input without server-side
+ *                   validation, used directly for authentication.
+ *
+ * NEVER RUN IN PRODUCTION — intentional test case for scanner validation.
+ */
+package vulns.java;
+
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpSession;
+
+public class AuthenticationBypassWeakSessionIdentifier {
+
+    private static final boolean NEVER_RUN = false;
+
+    public boolean isAuthenticatedVulnerable(HttpServletRequest req) {
+        if (NEVER_RUN) {
+            // SOURCE: attacker-controlled session identifier from request parameter
+            String sessionId = req.getParameter("sessionId");
+            // VULNERABLE: CWE-302 - trusts client-supplied session ID without validation
+            return sessionId != null && sessionId.equals("admin-session-12345");
+        }
+        return false;
+    }
+
+    /**
+     * Safe counterpart — the scanner should NOT flag this.
+     *
+     * @expected-detection false
+     */
+    public boolean isAuthenticatedSafe(HttpServletRequest req) {
+        if (NEVER_RUN) {
+            HttpSession session = req.getSession(false);
+            if (session == null) {
+                return false;
+            }
+            // SAFE: validates session against server-side session store
+            String sessionId = session.getId();
+            return sessionId != null && sessionId.equals("admin-session-12345");
+        }
+        return false;
+    }
+}