test-cases: add CWE-304 (go)

docs/VULNERABILITY_CATALOG.md

@@ -7,12 +7,12 @@ from each file's header comment, so this page cannot drift from the source.
 
 ## Totals
 
-- **Test cases:** 62
-- **Expected detections:** 62
-- **`VULNERABLE:` markers:** 123 (individual lines a scanner should flag)
-- **`SAFE:` markers:** 73 (lines a scanner must not flag — the false-positive control group)
+- **Test cases:** 63
+- **Expected detections:** 63
+- **`VULNERABLE:` markers:** 124 (individual lines a scanner should flag)
+- **`SAFE:` markers:** 74 (lines a scanner must not flag — the false-positive control group)
 - **Languages:** 8 — dotenv, go, java, javascript, json, python, ruby, text
-- **CWE categories:** 46 — CWE-20, CWE-22, CWE-78, CWE-79, CWE-89, CWE-90, CWE-95, CWE-113, CWE-117, CWE-190, CWE-201, CWE-209, CWE-256, CWE-295, CWE-321, CWE-327, CWE-330, CWE-338, CWE-346, CWE-347, CWE-352, CWE-362, CWE-377, CWE-384, CWE-489, CWE-502, CWE-506, CWE-532, CWE-601, CWE-611, CWE-614, CWE-639, CWE-643, CWE-681, CWE-759, CWE-798, CWE-862, CWE-915, CWE-918, CWE-942, CWE-943, CWE-1236, CWE-1321, CWE-1333, CWE-1336, CWE-1357
+- **CWE categories:** 47 — CWE-20, CWE-22, CWE-78, CWE-79, CWE-89, CWE-90, CWE-95, CWE-113, CWE-117, CWE-190, CWE-201, CWE-209, CWE-256, CWE-295, CWE-304, CWE-321, CWE-327, CWE-330, CWE-338, CWE-346, CWE-347, CWE-352, CWE-362, CWE-377, CWE-384, CWE-489, CWE-502, CWE-506, CWE-532, CWE-601, CWE-611, CWE-614, CWE-639, CWE-643, CWE-681, CWE-759, CWE-798, CWE-862, CWE-915, CWE-918, CWE-942, CWE-943, CWE-1236, CWE-1321, CWE-1333, CWE-1336, CWE-1357
 
 ## How coverage is scored
 
@@ -28,6 +28,7 @@ counts as a detection. See `docs/SCANNER_INTEGRATION.md`.
 |---|---|---|---|---|---|
 | OS command injection via exec.Command with a shell | [`cmd-injection-exec.go`](../vulns/go/cmd-injection-exec.go) | CWE-78 | critical | yes | 2 vuln / 1 safe |
 | Integer overflow and unchecked narrowing conversion | [`integer-overflow.go`](../vulns/go/integer-overflow.go) | CWE-190 | medium | yes | 2 vuln / 3 safe |
+| Missing multi-factor authentication verification during login | [`cwe-304-go.go`](../vulns/go/cwe-304-go.go) | CWE-304 | high | yes | 1 vuln / 1 safe |
 | SQL injection via fmt.Sprintf | [`sqli-fmt-sprintf.go`](../vulns/go/sqli-fmt-sprintf.go) | CWE-89 | critical | yes | 2 vuln / 1 safe |
 | Server-side request forgery via http.Get on a user-supplied URL | [`ssrf-http-get.go`](../vulns/go/ssrf-http-get.go) | CWE-918 | high | yes | 2 vuln / 2 safe |
 

vulns/VULNERABILITY_CATALOG.json

@@ -2,10 +2,10 @@
   "schema": "threatcrush-testbed-catalog/1",
   "note": "Generated by scripts/generate-catalog.py \u2014 do not edit by hand.",
   "totals": {
-    "test_cases": 62,
-    "expected_detections": 62,
-    "vulnerable_markers": 123,
-    "safe_markers": 73,
+    "test_cases": 63,
+    "expected_detections": 63,
+    "vulnerable_markers": 124,
+    "safe_markers": 74,
     "languages": [
       "dotenv",
       "go",
@@ -40,6 +40,7 @@
       "CWE-209",
       "CWE-256",
       "CWE-295",
+      "CWE-304",
       "CWE-321",
       "CWE-327",
       "CWE-330",
@@ -99,6 +100,29 @@
         46
       ]
     },
+    {
+      "id": "go-missing-mfa-verification",
+      "file": "vulns/go/cwe-304-go.go",
+      "title": "Missing multi-factor authentication verification during login",
+      "category": "go",
+      "language": "go",
+      "cwe": "CWE-304",
+      "cwes": [
+        "CWE-304"
+      ],
+      "severity": "high",
+      "expected_detection": true,
+      "description": "The application accepts a username and password without verifying",
+      "detection_target": "Taint flow from request input into an authentication check",
+      "safe_guard": "Guarded by the always-false `neverRun` constant plus an `ignore`",
+      "attribution": "line",
+      "vulnerable_lines": [
+        30
+      ],
+      "safe_lines": [
+        41
+      ]
+    },
     {
       "id": "go-integer-overflow",
       "file": "vulns/go/integer-overflow.go",

vulns/go/cwe-304-go.go

@@ -0,0 +1,58 @@
+// @id go-missing-mfa-verification
+// @test-case Missing multi-factor authentication verification during login
+// @cwe CWE-304
+// @severity high
+// @language go
+// @expected-detection true
+// @description The application accepts a username and password without verifying
+//              a one-time password (OTP) or other second-factor token. An attacker
+//              with stolen credentials can authenticate without MFA, bypassing
+//              the intended authentication strength.
+// @safe-guard Guarded by the always-false `neverRun` constant plus an `ignore`
+//              build tag; no authentication flow is ever executed.
+// @detection-target Taint flow from request input into an authentication check
+//                   that lacks a second-factor verification step.
+//
+// NEVER RUN IN PRODUCTION — intentional test case for scanner validation.
+
+//go:build ignore
+
+package vulns
+
+import (
+	"net/http"
+)
+
+func loginVulnerable(r *http.Request) bool {
+	if neverRun {
+		username := r.FormValue("username") // SOURCE: attacker-controlled
+		password := r.FormValue("password") // SOURCE: attacker-controlled
+		// VULNERABLE: CWE-304 - no OTP or second-factor check
+		return authenticate(username, password)
+	}
+	return false
+}
+
+func loginSafe(r *http.Request) bool {
+	if neverRun {
+		username := r.FormValue("username") // SOURCE
+		password := r.FormValue("password") // SOURCE
+		otp := r.FormValue("otp")           // SOURCE: second factor
+		// SAFE: verifies OTP before granting access
+		return authenticateWithOTP(username, password, otp)
+	}
+	return false
+}
+
+// authenticate is a stub that only checks username/password.
+func authenticate(username, password string) bool {
+	return username == "admin" && password == "secret"
+}
+
+// authenticateWithOTP is a stub that checks username/password and OTP.
+func authenticateWithOTP(username, password, otp string) bool {
+	return username == "admin" && password == "secret" && otp == "123456"
+}
+
+// neverRun is a constant that is always false to keep the code dead.
+const neverRun = false