test-cases: add CWE-73 (python)

docs/VULNERABILITY_CATALOG.md

@@ -7,12 +7,12 @@ from each file's header comment, so this page cannot drift from the source.
 
 ## Totals
 
-- **Test cases:** 62
-- **Expected detections:** 62
-- **`VULNERABLE:` markers:** 123 (individual lines a scanner should flag)
-- **`SAFE:` markers:** 73 (lines a scanner must not flag — the false-positive control group)
+- **Test cases:** 63
+- **Expected detections:** 63
+- **`VULNERABLE:` markers:** 124 (individual lines a scanner should flag)
+- **`SAFE:` markers:** 74 (lines a scanner must not flag — the false-positive control group)
 - **Languages:** 8 — dotenv, go, java, javascript, json, python, ruby, text
-- **CWE categories:** 46 — CWE-20, CWE-22, CWE-78, CWE-79, CWE-89, CWE-90, CWE-95, CWE-113, CWE-117, CWE-190, CWE-201, CWE-209, CWE-256, CWE-295, CWE-321, CWE-327, CWE-330, CWE-338, CWE-346, CWE-347, CWE-352, CWE-362, CWE-377, CWE-384, CWE-489, CWE-502, CWE-506, CWE-532, CWE-601, CWE-611, CWE-614, CWE-639, CWE-643, CWE-681, CWE-759, CWE-798, CWE-862, CWE-915, CWE-918, CWE-942, CWE-943, CWE-1236, CWE-1321, CWE-1333, CWE-1336, CWE-1357
+- **CWE categories:** 47 — CWE-20, CWE-22, CWE-73, CWE-78, CWE-79, CWE-89, CWE-90, CWE-95, CWE-113, CWE-117, CWE-190, CWE-201, CWE-209, CWE-256, CWE-295, CWE-321, CWE-327, CWE-330, CWE-338, CWE-346, CWE-347, CWE-352, CWE-362, CWE-377, CWE-384, CWE-489, CWE-502, CWE-506, CWE-532, CWE-601, CWE-611, CWE-614, CWE-639, CWE-643, CWE-681, CWE-759, CWE-798, CWE-862, CWE-915, CWE-918, CWE-942, CWE-943, CWE-1236, CWE-1321, CWE-1333, CWE-1336, CWE-1357
 
 ## How coverage is scored
 
@@ -71,6 +71,7 @@ counts as a detection. See `docs/SCANNER_INTEGRATION.md`.
 | Test case | File | CWE | Severity | Expected | Markers |
 |---|---|---|---|---|---|
 | CSV formula injection from untrusted spreadsheet cells | [`csv-formula-injection.py`](../vulns/python/csv-formula-injection.py) | CWE-1236 | medium | yes | 1 vuln / 1 safe |
+| Path traversal via user-controlled filename in file read operation | [`cwe-73-python.py`](../vulns/python/cwe-73-python.py) | CWE-73 | high | yes | 1 vuln / 1 safe |
 | Excessive user-record exposure in an API response | [`excessive-data-exposure.py`](../vulns/python/excessive-data-exposure.py) | CWE-201 | high | yes | 1 vuln / 1 safe |
 | Flask debug mode enabled in application configuration | [`flask-debug-enabled.py`](../vulns/python/flask-debug-enabled.py) | CWE-489 | high | yes | 1 vuln / 1 safe |
 | Hardcoded secret used to configure session signing | [`hardcoded-session-secret.py`](../vulns/python/hardcoded-session-secret.py) | CWE-798 | high | yes | 1 vuln / 1 safe |

vulns/VULNERABILITY_CATALOG.json

@@ -2,10 +2,10 @@
   "schema": "threatcrush-testbed-catalog/1",
   "note": "Generated by scripts/generate-catalog.py \u2014 do not edit by hand.",
   "totals": {
-    "test_cases": 62,
-    "expected_detections": 62,
-    "vulnerable_markers": 123,
-    "safe_markers": 73,
+    "test_cases": 63,
+    "expected_detections": 63,
+    "vulnerable_markers": 124,
+    "safe_markers": 74,
     "languages": [
       "dotenv",
       "go",
@@ -28,6 +28,7 @@
     "cwes": [
       "CWE-20",
       "CWE-22",
+      "CWE-73",
       "CWE-78",
       "CWE-79",
       "CWE-89",
@@ -791,6 +792,29 @@
         40
       ]
     },
+    {
+      "id": "py-cwe73-path-traversal-file-read",
+      "file": "vulns/python/cwe-73-python.py",
+      "title": "Path traversal via user-controlled filename in file read operation",
+      "category": "python",
+      "language": "python",
+      "cwe": "CWE-73",
+      "cwes": [
+        "CWE-73"
+      ],
+      "severity": "high",
+      "expected_detection": true,
+      "description": "User-controlled filename from a request parameter is passed directly",
+      "detection_target": "Taint flow from request input into open() without path",
+      "safe_guard": "The entire fixture is wrapped in `if False:` and cannot execute. It",
+      "attribution": "line",
+      "vulnerable_lines": [
+        25
+      ],
+      "safe_lines": [
+        39
+      ]
+    },
     {
       "id": "py-excessive-data-exposure",
       "file": "vulns/python/excessive-data-exposure.py",

vulns/python/cwe-73-python.py

@@ -0,0 +1,42 @@
+"""
+@id py-cwe73-path-traversal-file-read
+@test-case Path traversal via user-controlled filename in file read operation
+@cwe CWE-73
+@severity high
+@language python
+@expected-detection true
+@description User-controlled filename from a request parameter is passed directly
+             to open() without validation, allowing an attacker to read arbitrary
+             files on the system by using path traversal sequences like ../.
+@safe-guard The entire fixture is wrapped in `if False:` and cannot execute. It
+            reads only from an in-memory StringIO object and never touches disk.
+@detection-target Taint flow from request input into open() without path
+                  validation or sanitization.
+
+NEVER RUN IN PRODUCTION - intentional test case for scanner validation.
+"""
+
+
+if False:
+    import os
+
+    def read_file_vulnerable(request):
+        filename = request.args.get("filename")  # SOURCE: attacker-controlled
+        with open(filename, "r") as f:  # VULNERABLE: CWE-73
+            return f.read()
+
+    def safe_join(base_dir, filename):
+        # Resolve the path and ensure it stays within base_dir
+        full_path = os.path.realpath(os.path.join(base_dir, filename))
+        base_path = os.path.realpath(base_dir)
+        if not full_path.startswith(base_path + os.sep):
+            raise ValueError("Path traversal detected")
+        return full_path
+
+    def read_file_safe(request):
+        base_dir = "/var/data"  # example.com - not a real host
+        filename = request.args.get("filename")
+        safe_path = safe_join(base_dir, filename)  # SAFE: path validated
+        with open(safe_path, "r") as f:
+            return f.read()
+        # @expected-detection false