test-cases: add CWE-114 (python)

docs/VULNERABILITY_CATALOG.md

@@ -7,12 +7,12 @@ from each file's header comment, so this page cannot drift from the source.
 
 ## Totals
 
-- **Test cases:** 62
-- **Expected detections:** 62
-- **`VULNERABLE:` markers:** 123 (individual lines a scanner should flag)
-- **`SAFE:` markers:** 73 (lines a scanner must not flag — the false-positive control group)
+- **Test cases:** 63
+- **Expected detections:** 63
+- **`VULNERABLE:` markers:** 124 (individual lines a scanner should flag)
+- **`SAFE:` markers:** 74 (lines a scanner must not flag — the false-positive control group)
 - **Languages:** 8 — dotenv, go, java, javascript, json, python, ruby, text
-- **CWE categories:** 46 — CWE-20, CWE-22, CWE-78, CWE-79, CWE-89, CWE-90, CWE-95, CWE-113, CWE-117, CWE-190, CWE-201, CWE-209, CWE-256, CWE-295, CWE-321, CWE-327, CWE-330, CWE-338, CWE-346, CWE-347, CWE-352, CWE-362, CWE-377, CWE-384, CWE-489, CWE-502, CWE-506, CWE-532, CWE-601, CWE-611, CWE-614, CWE-639, CWE-643, CWE-681, CWE-759, CWE-798, CWE-862, CWE-915, CWE-918, CWE-942, CWE-943, CWE-1236, CWE-1321, CWE-1333, CWE-1336, CWE-1357
+- **CWE categories:** 47 — CWE-20, CWE-22, CWE-78, CWE-79, CWE-89, CWE-90, CWE-95, CWE-113, CWE-114, CWE-117, CWE-190, CWE-201, CWE-209, CWE-256, CWE-295, CWE-321, CWE-327, CWE-330, CWE-338, CWE-346, CWE-347, CWE-352, CWE-362, CWE-377, CWE-384, CWE-489, CWE-502, CWE-506, CWE-532, CWE-601, CWE-611, CWE-614, CWE-639, CWE-643, CWE-681, CWE-759, CWE-798, CWE-862, CWE-915, CWE-918, CWE-942, CWE-943, CWE-1236, CWE-1321, CWE-1333, CWE-1336, CWE-1357
 
 ## How coverage is scored
 
@@ -70,6 +70,7 @@ counts as a detection. See `docs/SCANNER_INTEGRATION.md`.
 
 | Test case | File | CWE | Severity | Expected | Markers |
 |---|---|---|---|---|---|
+| Command injection via untrusted input passed to subprocess with shell=True | [`cwe-114-python.py`](../vulns/python/cwe-114-python.py) | CWE-114 | high | yes | 1 vuln / 1 safe |
 | CSV formula injection from untrusted spreadsheet cells | [`csv-formula-injection.py`](../vulns/python/csv-formula-injection.py) | CWE-1236 | medium | yes | 1 vuln / 1 safe |
 | Excessive user-record exposure in an API response | [`excessive-data-exposure.py`](../vulns/python/excessive-data-exposure.py) | CWE-201 | high | yes | 1 vuln / 1 safe |
 | Flask debug mode enabled in application configuration | [`flask-debug-enabled.py`](../vulns/python/flask-debug-enabled.py) | CWE-489 | high | yes | 1 vuln / 1 safe |

vulns/VULNERABILITY_CATALOG.json

@@ -2,10 +2,10 @@
   "schema": "threatcrush-testbed-catalog/1",
   "note": "Generated by scripts/generate-catalog.py \u2014 do not edit by hand.",
   "totals": {
-    "test_cases": 62,
-    "expected_detections": 62,
-    "vulnerable_markers": 123,
-    "safe_markers": 73,
+    "test_cases": 63,
+    "expected_detections": 63,
+    "vulnerable_markers": 124,
+    "safe_markers": 74,
     "languages": [
       "dotenv",
       "go",
@@ -34,6 +34,7 @@
       "CWE-90",
       "CWE-95",
       "CWE-113",
+      "CWE-114",
       "CWE-117",
       "CWE-190",
       "CWE-201",
@@ -791,6 +792,29 @@
         40
       ]
     },
+    {
+      "id": "py-command-injection-subprocess",
+      "file": "vulns/python/cwe-114-python.py",
+      "title": "Command injection via untrusted input passed to subprocess with shell=True",
+      "category": "python",
+      "language": "python",
+      "cwe": "CWE-114",
+      "cwes": [
+        "CWE-114"
+      ],
+      "severity": "high",
+      "expected_detection": true,
+      "description": "User-controlled input is concatenated into a shell command string and",
+      "detection_target": "Taint flow from request input into subprocess.Popen with shell=True",
+      "safe_guard": "The entire fixture is wrapped in `if False:` and cannot execute. It",
+      "attribution": "line",
+      "vulnerable_lines": [
+        26
+      ],
+      "safe_lines": [
+        31
+      ]
+    },
     {
       "id": "py-excessive-data-exposure",
       "file": "vulns/python/excessive-data-exposure.py",

vulns/python/cwe-114-python.py

@@ -0,0 +1,33 @@
+"""
+@id py-command-injection-subprocess
+@test-case Command injection via untrusted input passed to subprocess with shell=True
+@cwe CWE-114
+@severity high
+@language python
+@expected-detection true
+@description User-controlled input is concatenated into a shell command string and
+             executed via subprocess with shell=True, allowing arbitrary command
+             execution on the host system.
+@safe-guard The entire fixture is wrapped in `if False:` and cannot execute. It
+            only constructs command strings and never invokes subprocess.
+@detection-target Taint flow from request input into subprocess.Popen with shell=True
+                  without proper argument list usage.
+
+NEVER RUN IN PRODUCTION - intentional test case for scanner validation.
+"""
+
+
+if False:
+    import subprocess
+
+    def run_command_vulnerable(request):
+        user_input = request.args.get("cmd")  # SOURCE: attacker-controlled
+        command = "echo " + user_input
+        subprocess.Popen(command, shell=True)  # VULNERABLE: CWE-114
+        return "Command executed"
+
+    def run_command_safe(request):
+        user_input = request.args.get("cmd")
+        # SAFE: using argument list without shell=True
+        subprocess.Popen(["echo", user_input])  # @expected-detection false
+        return "Command executed"