Skip to content

upgrade lettuce and fix deprecation warning#1076

Merged
yisraelU merged 2 commits intoprofunktor:series/2.xfrom
yisraelU:Lettuce-7.2
Dec 16, 2025
Merged

upgrade lettuce and fix deprecation warning#1076
yisraelU merged 2 commits intoprofunktor:series/2.xfrom
yisraelU:Lettuce-7.2

Conversation

@yisraelU
Copy link
Copy Markdown
Collaborator

No description provided.

@yisraelU yisraelU merged commit 6bfb7e4 into profunktor:series/2.x Dec 16, 2025
2 checks passed
yisraelU added a commit to yisraelU/redis4cats that referenced this pull request Dec 25, 2025
* upgrade lettuce and fix deprecation warning

* fix api change
@bpholt
Copy link
Copy Markdown

bpholt commented Dec 29, 2025

Since this was a major version update to lettuce, should merging this have triggered a major version update to this library? (I think if the bincompat surface didn't change, it's probably fine either way, but I think they did remove some deprecated methods, so it seems risky to me?)

@yisraelU
Copy link
Copy Markdown
Collaborator Author

@bpholt I'm not sure whats accepted practice.
The goal of this library is a wrapper and our surface preserves binary compatibility . On the other hand , there is a unsafe api call that exposes the underlying Lettuce api

@satorg
Copy link
Copy Markdown

satorg commented Dec 29, 2025

@yisraelU , sorry for jumping into the conversation, but since the underlying library is not fully enclosed, according to semantic versioning principles, it would be safer to bump up the major here too. Moreover, given that #1079 introduces binary incompatibilites as well, I'd suppose that upgrading the major is the way to go for the next release.

@mmienko
Copy link
Copy Markdown
Collaborator

mmienko commented Dec 30, 2025

Version bump is reasonable in this situation. There’s the unsafe api and all the connection builders which take Lettuce builders and options.

@yisraelU
Copy link
Copy Markdown
Collaborator Author

okay, I think it's a bit of a gray area but definitely makes sense . I'll add a warning to the release that contains the breaking change of the underlying library.
Going forward, I'll open a series/3.x branch where we can open PR's against and potentially aggregate all other binary breaking changes.

@yisraelU
Copy link
Copy Markdown
Collaborator Author

Rollbacked here #1082
Will create new release and mark old release do not use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants