upgrade lettuce and fix deprecation warning#1076
upgrade lettuce and fix deprecation warning#1076yisraelU merged 2 commits intoprofunktor:series/2.xfrom
Conversation
* upgrade lettuce and fix deprecation warning * fix api change
|
Since this was a major version update to lettuce, should merging this have triggered a major version update to this library? (I think if the bincompat surface didn't change, it's probably fine either way, but I think they did remove some deprecated methods, so it seems risky to me?) |
|
@bpholt I'm not sure whats accepted practice. |
|
@yisraelU , sorry for jumping into the conversation, but since the underlying library is not fully enclosed, according to semantic versioning principles, it would be safer to bump up the major here too. Moreover, given that #1079 introduces binary incompatibilites as well, I'd suppose that upgrading the major is the way to go for the next release. |
|
Version bump is reasonable in this situation. There’s the unsafe api and all the connection builders which take Lettuce builders and options. |
|
okay, I think it's a bit of a gray area but definitely makes sense . I'll add a warning to the release that contains the breaking change of the underlying library. |
|
Rollbacked here #1082 |
No description provided.