This repository was archived by the owner on Jul 26, 2024. It is now read-only.
Open
Conversation
ckendrick
force-pushed
the
feature/hip
branch
from
d36c506 to
9a8d70f
Compare
13 tasks
quantumsteve
suggested changes
Nov 17, 2021
Contributor
quantumsteve
left a comment
quantumsteve
left a comment
There was a problem hiding this comment.
Please double-check that we need find_package(CUDA).
CMakeLists.txt
Outdated
| message(STATUS "HIP Libraries: ${HIP_LIBRARIES}") | ||
|
|
||
| if(KRONMULT_PLATFORM_NVCC) | ||
| find_package(CUDA 9.0 REQUIRED) |
Contributor
There was a problem hiding this comment.
This is a step back from enable_language (CUDA). Can we stay with first-class language support?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces CUDA with HIP and adjusts
CMakeLists.txtfor compiling on both AMD and NVIDIA platforms.