Add and Leverage Linux Connectivity Callback Introspection, Mutation, and Action Delegation Methods#43062
Merged
mergify[bot] merged 9 commits intoproject-chip:masterfrom Mar 13, 2026
Conversation
gerickson
force-pushed
the
user/gerickson/github-issue-42516-connectivity-callback-support-methods
branch
from
bc53c60 to
4e48856
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces new callback setters and delegation methods to improve encapsulation and reduce code duplication within the Linux ConnectivityManagerImpl. The changes are well-structured and successfully centralize callback handling. All identified issues, including a critical one regarding uninitialized member variables and several medium-severity issues related to function parameter passing conventions, remain valid and should be addressed for consistency, performance, and to prevent undefined behavior.
gerickson
force-pushed
the
user/gerickson/github-issue-42516-connectivity-callback-support-methods
branch
5 times, most recently
from
923c954 to
6e18096
Compare
gerickson
changed the title
Contributor
Author
|
@enkiusz or @andy31415, any thoughts on this? |
Contributor
Author
|
@andy31415, any thoughts on this? |
Contributor
Author
|
@tersal, @arkq, or @andy31415, any thoughts on this? |
andy31415
reviewed
Feb 23, 2026
andy31415
reviewed
Feb 23, 2026
andy31415
reviewed
Feb 23, 2026
andy31415
reviewed
Feb 23, 2026
andy31415
reviewed
Feb 23, 2026
andy31415
reviewed
Feb 23, 2026
andy31415
reviewed
Feb 23, 2026
gerickson
force-pushed
the
user/gerickson/github-issue-42516-connectivity-callback-support-methods
branch
4 times, most recently
from
0ea7b3e to
78c8e81
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #43062 +/- ##
=======================================
Coverage 54.04% 54.05%
=======================================
Files 1548 1548
Lines 106696 106704 +8
Branches 13314 13313 -1
=======================================
+ Hits 57669 57677 +8
Misses 49027 49027 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@andy31415, I had one open question for you; that aside, I think this incorporates all of your requested feedback. |
gerickson
force-pushed
the
user/gerickson/github-issue-42516-connectivity-callback-support-methods
branch
from
78c8e81 to
854e504
Compare
Contributor
Author
|
@andy31415, all outstanding comments resolved. Should be good to go for your final review. |
andy31415
approved these changes
Mar 5, 2026
Contributor
Author
enkiusz
reviewed
Mar 6, 2026
Contributor
gerickson
force-pushed
the
user/gerickson/github-issue-42516-connectivity-callback-support-methods
branch
from
854e504 to
60eac26
Compare
gerickson
force-pushed
the
user/gerickson/github-issue-42516-connectivity-callback-support-methods
branch
from
60eac26 to
2545f54
Compare
gerickson
force-pushed
the
user/gerickson/github-issue-42516-connectivity-callback-support-methods
branch
from
2545f54 to
5c827cd
Compare
|
PR #43062: Size comparison from ba97f02 to 5c827cd Full report (30 builds for bl602, bl616, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
This more accurately reflects its set-scan-and-clear usage.
This more accurately reflects its set-connect-and-clear usage.
These three methods consolidate the handling and dispatch of scan, connect, and network status change action delegation callback invocation and, for scan and connect, post-invocation nullification.
This not only makes it easier to keep callback members private as implementations fan out from the current, single wpa_supplicant implementation but also reduces duplication among those implementations for common callback-related operations.
Previously, the status change callback was initialized with a default initializer and the connect and scan callbacks were initialized in the explicit initializer. With this change, all three are now initialized in the explicit initializer.
gerickson
force-pushed
the
user/gerickson/github-issue-42516-connectivity-callback-support-methods
branch
from
5c827cd to
ebc639e
Compare
Contributor
Author
|
@enkiusz, any additional thoughts on this one? |
enkiusz
approved these changes
Mar 13, 2026
Contributor
Author
|
Thanks @andy31415 and @enkiusz! |
gerickson
deleted the
user/gerickson/github-issue-42516-connectivity-callback-support-methods
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds two new callback setters as peers to the existing
SetNetworkStatusChangeCallback:SetConnectCallbackSetScanCallbackand adds three new callback-related action delegation methods:
OnConnectResultOnScanFinishedOnStatusChangeand adds two new callback-related introspection methods:
IsWiFiStationConnectingIsWiFiStationScanningThe three action delegation methods consolidate the handling and dispatch of scan, connect, and network status change action delegation callback invocation and, for scan and connect, post-invocation nullification.
Collectively, these seven methods not only make it easier to keep common callback members private as implementations fan out from the current, single
wpa_supplicantimplementation but also reduces duplication among those implementations for common callback-related operations.Related issues
#42516
Testing
An armvl-unknown-linux-gnu device has been successfully paired / commissioned using the iOS 26.2 Apple "Home" app with a Connectivity Manager implementation using this infrastructure.