Introduce Groupcast to all-devices-app#43092
Merged
andy31415 merged 10 commits intoproject-chip:masterfrom Feb 18, 2026
Merged
Conversation
\#### Summary - Add the registration. - Reverse de-init order to match correct dependencies injection best practices. \#### Testing done - Ran the app successfully, showing the cluster present Fixes project-chip#43090
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the Groupcast cluster to the all-devices-app's root node device. The changes include adding the necessary build dependency, including headers, and registering the cluster. A notable improvement is the reordering of cluster un-registration in UnRegister to be the reverse of the registration order, which is a best practice for dependency management. The changes are logical and well-implemented. I have one suggestion for improving code consistency.
|
PR #43092: Size comparison from 05d46e6 to 6fa2fbd Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
PR #43092: Size comparison from 05d46e6 to b2cf91d Full report (4 builds for nrfconnect, realtek, stm32)
|
|
PR #43092: Size comparison from 05d46e6 to 20d1d9b Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
jmartinez-silabs
approved these changes
Feb 12, 2026
rcasallas-silabs
approved these changes
Feb 17, 2026
andy31415
approved these changes
Feb 17, 2026
|
PR #43092: Size comparison from c7a4e4e to da60e04 Full report (27 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32)
|
Contributor
|
Bypassing telink failure on merge - this should be resolved in master but do not want a full CI run. |
github-project-automation
Bot
moved this to Done
in [Matter 1.6] Groupcast and group improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing done
Fixes #43090