Feat/73 Write frontend for Admin/Interesting facts block#2
Merged
VolodymyrShapoval merged 9 commits intoDec 17, 2025
Merged
Conversation
…ed data structures
…k with styling and form enhancements
…block with improved form handling and validation
…oved form handling, validation, and styling adjustments
Vektor19
requested changes
Dec 16, 2025
…terestingFactsModal
|
Vektor19
approved these changes
Dec 17, 2025
Contributor
Vektor19
left a comment
There was a problem hiding this comment.
All comments were resolved. Well done!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



dev
GitHub
Code reviewers
Second Level Review
Summary of issue
This pull request implements a major refactor and feature upgrade for the Interesting Facts admin modal, focusing on improved UX, stricter validation, and more reliable image and fact creation flows. The changes include a full rewrite of the modal component, new and responsive styles, enhanced form management, and improved error handling for both fact and image creation. There are also some API and store interface updates to support the new logic.
Interesting Facts Admin Modal Refactor and UX Improvements:
InterestingFactsAdminModal.component.tsxto use Ant Design'sFormfor better validation, live character counters, and improved image upload handling. Added support for both fact creation and editing, with image upload now required only for new facts. Improved error handling and user feedback on failures.InterestingFactsAdminModal.styles.scss) with responsive and accessible styles, including input counters, upload area improvements, and mobile adaptations.API and Store Interface Adjustments:
createmethod for facts now expects aFactCreatetype, aligning the frontend and backend data contracts.createFactandcreateImagemethods in their respective stores (facts-store.ts,image-store.ts) to return the created object ornullon error, and to provide better error logging and state updates.Image Alt Text Handling:
altattribute of fact images: now uses the fact's title instead of the image description, both when setting image details and when adding a new fact.Store Interface Fixes:
modalStoreto the root store interface to ensure correct typing and access throughout the app.CHECK LIST