Skip to content

Feat/246/create signup login pages#4

Merged
shribakb1 merged 6 commits into
mainfrom
feat/246/create_signup_login_pages
Dec 28, 2025
Merged

Feat/246/create signup login pages#4
shribakb1 merged 6 commits into
mainfrom
feat/246/create_signup_login_pages

Conversation

@shribakb1
Copy link
Copy Markdown
Contributor

@shribakb1 shribakb1 commented Dec 25, 2025

dev

Code reviewers

Second Level Review

Summary of issue

The project needed a full authentication flow: registration (signup), login, logout, and UI/UX for these features.
Admin panel and protected routes required user authentication.

Summary of change

Login & Signup Pages:

Created dedicated Login and Signup pages with Ant Design components, validation, password strength indicator, and toast notifications.
Added Google login button placeholder.
Improved form spacing and UI per Figma.
Authentication Logic:

Integrated frontend with backend /api/Users/Register, /api/Users/Login, /api/Users/Logout endpoints.

Tokens and expiration are persisted in local storage for session continuity.
Logout clears all tokens and user data.

Testing approach

Manual testing of login, signup, and logout flows.
Verified protected routes redirect when not logged in
Confirmed localStorage persistence and logout clearing.
Validated error messages and form validation.

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
4.6% Duplication on New Code (required ≤ 3%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link
Copy Markdown
Contributor

@Vektor19 Vektor19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the amazing functionality! Everthing looks clean.

Copy link
Copy Markdown
Contributor

@VolodymyrShapoval VolodymyrShapoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well-structured work! Great job

Copy link
Copy Markdown
Contributor

@Ammoniy Ammoniy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done

Comment thread src/app/api/agent.api.ts
@shribakb1 shribakb1 merged commit 438405d into main Dec 28, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants