Skip to content

Task/ssad 115/create login with google#126

Closed
Darsicl wants to merge 38 commits into
devfrom
task/SSAD-115/Create_Login_with_Google
Closed

Task/ssad 115/create login with google#126
Darsicl wants to merge 38 commits into
devfrom
task/SSAD-115/Create_Login_with_Google

Conversation

@Darsicl
Copy link
Copy Markdown
Contributor

@Darsicl Darsicl commented Mar 4, 2026

dev

JIRA

Code reviewers

Summary of issue

Create an accessibility to LogIn using Google Auth

Authentication Flow: Fixed JWT and Cookie scheme conflicts in Program.cs. Integrated Google OAuth with automatic user registration.

Business Logic:
Updated LoginWithGoogleHandler to handle automatic user creation and role assignment.

Mapping:
Updated AuthProfile (AutoMapper) to correctly map Name and Surname from Google DTO to ApplicationUser.

Testing:
Added LoginWithGoogleDTOValidatorTests, LoginWithGoogleHandlerTests
Infrastructure: Updated docker-compose to support a unified SQL Server instance with multiple databases.

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

@Darsicl Darsicl added the task Regular task label Mar 4, 2026
@Darsicl Darsicl self-assigned this Mar 4, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 4, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
29.1% Coverage on New Code (required ≥ 80%)
5.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link
Copy Markdown
Contributor

@Serpantyn Serpantyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@Darsicl
Copy link
Copy Markdown
Contributor Author

Darsicl commented Mar 4, 2026

"Closing this in favor of PR #127 due to branch restructuring"

@Darsicl Darsicl deleted the task/SSAD-115/Create_Login_with_Google branch March 4, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

task Regular task

Projects

Status: To Review

Development

Successfully merging this pull request may close these issues.

2 participants