Fixing Bug/ssad 33 fix houses.zip

[khomenko-a]

dev

JIRA

• Task #13

Summary of issue

The database synchronization process in SaveToponymsToDbAsync was unoptimized (caused full table truncation and row-by-row insertion). Additionally, the path for houses.zip was hardcoded and the large binary file was tracked in the repository root.

Summary of change

• Refactored SaveToponymsToDbAsync:
  • Replaced row-by-row operations with batch operations (CreateRange, DeleteRange) for better performance.
  • Implemented incremental updates: now the code calculates differences instead of recreating the whole table.
• File Management:
  • Configured houses.zip to be downloaded at runtime to the Resources folder.
  • Added houses.csv to .gitignore to prevent tracking large files.

CHECK LIST

• СI passed
• Сode coverage >=95%
• PR is reviewed manually again (to make sure you have 100% ready code)
• All reviewers agreed to merge the PR
• I've checked new feature as logged in and logged out user if needed
• PR meets all conventions

[sonarqubecloud]

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

[DrFaust555]

Approved after the next remarks:

1. Search for deletion — N+1 query:

foreach (var candidate in possibleToponymsToDelete)
{
var entity = await _repository.ToponymRepository.GetFirstOrDefaultAsync(t =>
t.Gromada == candidate.Gromada &&
t.Coordinate.Latitude == candidate.Coordinate.Latitude &&
...);
}
Each candidate is a separate query to the database. If dataToDelete has 100 records, it is 100 queries. It can be optimized through one GetAllAsync with Contains, but for Take(20) it is not critical.

Now I suspect the following (I need to check, I could be wrong myself!):

2. News tests in PR:

PR contains 8 News test files from PR #63. You need to either rebase to the current dev (if #63 has already been merged), or it will be a conflict.

3. .gitignore not updated:

The PR description says "adding houses.csv to .gitignore". houses.csv has been removed from git, but without .gitignore it can be re-committed.

[DrFaust555]

Add entries for houses.csv, data.csv and houses.zip to .gitignore so that they do not end up in the repo after local launch. Also fix N+1 query in SaveToponymsToDbAsync — now in the foreach loop for each candidate for deletion there is a separate GetFirstOrDefaultAsync query, this needs to be replaced with a single query that will extract all the necessary records. And remove lines from Controllers\Newss\ and Controllers\Analytics\ from .csproj — they are not relevant to your task.

[sonarqubecloud]

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
D Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[DrFaust555]

Approved