Fix CI/CD pipeline#326
Merged
Merged
Conversation
Refactor paths in deploy-webapi-prod.yml to use a new directory structure. Updated `AZURE_WEBAPP_PACKAGE_PATH`, `API_IMPORT_SPECIFICATION_PATH`, `API_IMPORT_DLL`, and `WORKING_DIRECTORY` to reflect the changes from `Streetcode.WebApi` to `Streetcode/Streetcode.WebApi`, ensuring consistency with forward slashes.
- Added new environment variables: PUBLISH_DIRECTORY and BUILD_DLL. - Introduced a job step to generate the Open API Specification Document using Swashbuckle CLI. - Set working directory to WORKING_DIRECTORY and output path to PUBLISH_DIRECTORY. - Enhanced swagger tofile command with --startupAssembly and --startupType parameters.
Removed the separate step for generating the Open API Specification Document. Replaced it with a consolidated step that installs the Swashbuckle CLI .NET Global Tool and executes the `swagger tofile` command in one go, specifying the working directory for improved clarity and efficiency.
Modified `deploy-webapi-prod.yml` to enhance the Swashbuckle CLI installation process by adding the tool's path to the environment. Updated the output path for the generated Swagger JSON file to use `${{ env.AZURE_WEBAPP_PACKAGE_PATH }}` and streamlined the installation and generation commands into a single step.
Modified the `deploy-webapi-prod.yml` file to change the method of adding the .NET tools directory to the environment path. Replaced the deprecated `echo "::add-path::$HOME/.dotnet/tools"` with `echo "$HOME/.dotnet/tools" >> $GITHUB_PATH` to align with current GitHub Actions practices.
Renamed the Open API specification generation step to "Generate OpenAPI spec (Windows)" in `deploy-webapi-prod.yml`. Updated the command to handle Windows-specific paths and adjusted the appending of the `GITHUB_PATH` variable accordingly, while keeping the Swashbuckle CLI installation command unchanged.
This commit removes the step in `deploy-webapi-prod.yml` that generated an OpenAPI specification using the Swashbuckle CLI. The step included the installation of the Swashbuckle CLI tool globally and the command to create a Swagger JSON file. Other deployment steps for publishing the application and uploading artifacts remain intact.
This commit removes the step that imports an API into Azure API Management from the `deploy-webapi-prod.yml` file. Additionally, the `WORKING_DIRECTORY` and `PUBLISH_DIRECTORY` environment variables have been deleted, while other variables related to the API import remain unchanged.
Modified paths in `deploy-userservice-prod.yml` to use forward slashes for better cross-platform compatibility. Updated the working directory structure and removed steps for generating the Open API Specification Document and importing the API into Azure API Management, streamlining the deployment process.
Replaced service principal credentials in
`deploy-userservice-prod.yml` and `deploy-webapi-prod.yml`.
The previous credentials (`${{ secrets.apim_streetcode_prod_pl_SPN }}`)
were updated to `${{ secrets.USERSERVICE_SPN }}` and
`${{ secrets.WEBAPI_SPN }}` for user service and web API
deployments, respectively.
KobMiles
requested review from
a team,
AndreyDot,
Andriy1409,
DenysSaiuk,
ErikSavchynAI,
Ilbko,
L1ght1234,
Tolia645 and
Yazheviika
Closed
|
AndreyDot
approved these changes
Jun 24, 2025
L1ght1234
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dev
Code reviewers
Summary of issue
#323
Summary of change
Fix CI/CD pipeline
CHECK LIST