fix/43: GetToponymsByStreetcodeIdHandler.Handle() correctly returns fail result#45
Open
PenultimateBoss wants to merge 15 commits into
Open
fix/43: GetToponymsByStreetcodeIdHandler.Handle() correctly returns fail result#45PenultimateBoss wants to merge 15 commits into
PenultimateBoss wants to merge 15 commits into
Conversation
…l result when no toponyms found
snitochka
reviewed
May 11, 2026
snitochka
reviewed
May 11, 2026
…etToponymsByStreetcodeIdHandler.cs Co-authored-by: snitochka <107924262+snitochka@users.noreply.github.com>
snitochka
reviewed
May 11, 2026
PenultimateBoss
pushed a commit
that referenced
this pull request
May 11, 2026
…etToponymsByStreetcodeIdHandler.cs Co-authored-by: snitochka <107924262+snitochka@users.noreply.github.com>
Contributor
Author
|
Let me fix this later |
Contributor
Author
|
If we call toponyms.AnyAsync() and also return toponyms, does it mean we will send db request twice? |
snitochka
reviewed
May 12, 2026
…l result when no toponyms found
…etToponymsByStreetcodeIdHandler.cs Co-authored-by: snitochka <107924262+snitochka@users.noreply.github.com>
…etToponymsByStreetcodeIdHandler.cs Co-authored-by: snitochka <107924262+snitochka@users.noreply.github.com>
…tps://github.com/project-studying-dotnet/Streetcode-Server-May2026 into fix/43/fix_get_toponyms_by_streetcode_id_handler
…etToponymsByStreetcodeIdHandler.cs Co-authored-by: snitochka <107924262+snitochka@users.noreply.github.com>
|
❌ The last analysis has failed. |
|
andrxpie
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetToponymsByStreetcodeIdHandler.Handle() now returns fail result when GetAllAsync() method returns empty enumerable
Fixes #43