Test/6/streetcode text#51
Open
NikitaPankin wants to merge 15 commits into
Open
Conversation
…owArgumentNullException_WhenInputIsNull
…PassesOriginalText_ToService
|
❌ The last analysis has failed. |
| It.IsAny<Func<IQueryable<TextEntity>, IIncludableQueryable<TextEntity, object>>?>())) | ||
| .ReturnsAsync(texts); | ||
|
|
||
| this.mapperMock |
Contributor
There was a problem hiding this comment.
Setup mapper like this, forces handler to always return "textDtos", regardless of the result of GetAllAsync() method. This causes test to always pass. Replace mapper mock with mapper itself to fix this problem. Check other tests for the same problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dev
JIRA
Code reviewers
Second Level Review
Summary of issue
Write unit tests for StreetCode/Text
Summary of change
Add tests for GetAllTextsHandler, GetTextByIdHandler, GetTextByStreetcodeIdHandler, GetParsedTextAdminPreviewHandler and AddTermsToTextService
Testing approach
ToDo
CHECK LIST