fix: wildcard server sends interactions to all clients#1339
Open
dogancanbakir wants to merge 1 commit intodevfrom
Open
fix: wildcard server sends interactions to all clients#1339dogancanbakir wants to merge 1 commit intodevfrom
dogancanbakir wants to merge 1 commit intodevfrom
Conversation
In wildcard mode, GetInteractionsWithId clears data on first poll, starving subsequent clients. Use per-consumer read offsets so each client independently tracks its position in the shared data buffer. Buffer cap is configurable via INTERACTSH_MAX_SHARED_INTERACTIONS env var (default 10000).
Neo - PR Security ReviewNo security issues found Highlights
Hardening Notes
Comment |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-wc),GetInteractionsWithIdclears data on the first client's poll, starving all other clientsGetInteractionsWithIdForConsumer) so each client independently tracks its position in the shared data bufferINTERACTSH_MAX_SHARED_INTERACTIONS, default 10000)Fixes #1296