fix: add nil check for opts in executeWithRuntime (#7248)

[DrGalio]

Summary

Adds a nil check before accessing opts.ExecutionId in executeWithRuntime in pkg/js/compiler/pool.go.

Problem

Line 115 accesses opts.ExecutionId without checking if opts is nil first:

runtime.SetContextValue("executionId", opts.ExecutionId)

However, other accesses to opts in the same function already perform nil checks:

• Line 86: if opts != nil && opts.Cleanup != nil
• Line 109: if opts != nil && opts.Callback != nil

This inconsistency means calling executeWithRuntime with a nil opts will panic.

Fix

Wrap the runtime.SetContextValue call in an if opts != nil guard, consistent with the existing nil checks in the function.

Changes

• pkg/js/compiler/pool.go: Added nil check before opts.ExecutionId access

Closes #7248

Summary by CodeRabbit

• Bug Fixes
  • Fixed a potential runtime error that could occur when processing execution requests.

[neo-by-projectdiscovery-dev]

Neo - PR Security Review

No security issues found

Highlights

• Adds nil check before accessing opts.ExecutionId, preventing a potential panic
• Makes nil handling consistent across the executeWithRuntime function
• No security-impacting changes to JavaScript execution logic

_{Comment @pdneo help for available commands. · Open in Neo}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4ca6e055-e079-4ab3-bc6d-f4a227992231

📥 Commits

Reviewing files that changed from the base of the PR and between 6eda56f and 03da46c.

📒 Files selected for processing (1)

• pkg/js/compiler/pool.go

---

Walkthrough

Fixed a missing nil check in executeWithRuntime function that unconditionally dereferenced opts when setting the executionId context value, adding defensive programming to prevent potential panic when opts is nil.

Changes

Cohort / File(s)	Summary
Nil Check Fix pkg/js/compiler/pool.go	Added defensive nil check before dereferencing opts for opts.ExecutionId in executeWithRuntime function to prevent panic when opts argument is nil.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A rabbit hops through code with care,
Where nil pointers once lurked there,
A simple check, a guard so tight,
Makes execution safe and right! 🐰✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: adding a nil check for opts in executeWithRuntime function, with direct reference to the related issue.
Linked Issues check	✅ Passed	The PR directly addresses issue #7248 by adding the required nil check for opts before accessing ExecutionId, matching the expected behavior outlined in the issue.
Out of Scope Changes check	✅ Passed	All changes are scoped to the identified issue; only pkg/js/compiler/pool.go is modified to add the nil check as required by #7248.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

You can disable poems in the walkthrough.

Disable the reviews.poem setting to disable the poems in the walkthrough.

[themavik]

test review from automation - please ignore