Skip to content

fix: -l -list option does not understand multiple prefixes comma-separated#921

Closed
artylobos wants to merge 1 commit intoprojectdiscovery:mainfrom
artylobos:fix/issue-859
Closed

fix: -l -list option does not understand multiple prefixes comma-separated#921
artylobos wants to merge 1 commit intoprojectdiscovery:mainfrom
artylobos:fix/issue-859

Conversation

@artylobos
Copy link
Copy Markdown

@artylobos artylobos commented Feb 24, 2026

What does this PR do?

Fixes #859

/claim #859

Description

This PR addresses the issue: -l -list option does not understand multiple prefixes comma-separated

See #859 for details.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Summary by CodeRabbit

  • New Features
    • Input lines can now contain multiple comma-separated items, with each item individually processed. This enhancement applies to both file-based and STDIN inputs.

@neo-by-projectdiscovery-dev
Copy link
Copy Markdown

neo-by-projectdiscovery-dev bot commented Feb 24, 2026

Neo Security Audit

No security issues found

Comment @neo help for available commands. · Open in Neo

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d13b67f and 4beee45.

📒 Files selected for processing (1)
  • internal/runner/runner.go

Walkthrough

The normalizeAndQueueInputs function in internal/runner/runner.go was updated to parse comma-separated input items within single lines from input files or STDIN. Each comma-separated item is trimmed and individually queued, addressing the discrepancy between command-line and file-based input handling.

Changes

Cohort / File(s) Summary
Input Parsing Enhancement
internal/runner/runner.go
Modified line-splitting logic in normalizeAndQueueInputs to support comma-separated items. Items are now trimmed of whitespace and processed individually via processInputItem, affecting both file-based and STDIN input sources.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Commas once danced in a single line,
Split by logic, now they align,
File or STDIN, all treated the same,
Multiple inputs in one frame!
Hop, hop, hooray! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing the -l/--list option to support multiple comma-separated prefixes, which directly aligns with the code changes in normalizeAndQueueInputs that now split comma-separated items.
Linked Issues check ✅ Passed The code changes directly address issue #859 by modifying input parsing in normalizeAndQueueInputs to split comma-separated items on each line, enabling the -l/--list option to handle comma-separated prefixes identically to the -u option.
Out of Scope Changes check ✅ Passed All changes are scoped to the input parsing logic in normalizeAndQueueInputs, directly addressing the comma-separated prefix handling requirement without introducing unrelated modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@artylobos
Copy link
Copy Markdown
Author

Hi, gentle ping on this PR. It fixes the -l list option handling for comma-separated prefixes as described in #859. Happy to address any feedback. Thanks!

@Mzack9999
Copy link
Copy Markdown
Member

Thank you for the contribution! This issue has been resolved by #953 which was merged with the same approach along with a dedicated test. Closing as superseded.

@Mzack9999 Mzack9999 closed this Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

-l -list option does not understand multiple prefixes, comma-separated in a single line

2 participants