Skip to content

Potential fix for code scanning alert no. 6: Unsafe HTML constructed from library input #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
projectedanx merged 4 commits into from
Jul 6, 2026
Merged

Potential fix for code scanning alert no. 6: Unsafe HTML constructed from library input #241

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1654982
Potential fix for code scanning alert no. 6: Unsafe HTML constructed …
projectedanx Jul 6, 2026
9729597
Merge branch 'master' into alert-autofix-6
projectedanx Jul 6, 2026
97a58c0
Update js/jquery.cal.js
projectedanx Jul 6, 2026
d05deed
Update js/jquery.cal.js
projectedanx Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 31 additions & 9 deletions js/jquery.cal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,18 +84,40 @@
table.append('<tbody></tbody>');

// month select field
var monthselect = '<select name="month">';
for (var i in l10n_cal_month) monthselect += '<option value="'+i+'">'+l10n_cal_month[i]+'</option>';
monthselect += '</select>';
var monthselect = jQuery('<select name="month"></select>');
jQuery.each(l10n_cal_month, function(i, monthName) {
monthselect.append(jQuery('<option></option>').val(i).text(monthName));
});

// year select field
var yearselect = '<select name="year">';
for (var i in years) yearselect += '<option>'+years[i]+'</option>';
yearselect += '</select>';
var yearselect = jQuery('<select name="year"></select>');
for (var i = 0; i < years.length; i++) {
yearselect.append(jQuery('<option></option>').text(years[i]));
}

jQuery("thead",table).append('<tr class="controls"><th colspan="7"><span class="prevMonth">&laquo;</span>&nbsp;'+monthselect+yearselect+'&nbsp;<span class="nextMonth">&raquo;</span></th></tr>');
jQuery("thead",table).append('<tr class="days"><th>'+l10n_cal_days[0]+'</th><th>'+l10n_cal_days[1]+'</th><th>'+l10n_cal_days[2]+'</th><th>'+l10n_cal_days[3]+'</th><th>'+l10n_cal_days[4]+'</th><th>'+l10n_cal_days[5]+'</th><th>'+l10n_cal_days[6]+'</th></tr>');
jQuery("tfoot",table).append('<tr><td colspan="2"><span class="today">'+l10n_cal_today+'</span></td><td colspan="3">&nbsp;</td><td colspan="2"><span class="close">'+l10n_cal_close+'</span></td></tr>');
var controlsRow = jQuery('<tr class="controls"></tr>');
var controlsHeader = jQuery('<th colspan="7"></th>');
controlsHeader.append(jQuery('<span class="prevMonth"></span>').text('«'));
controlsHeader.append('\u00a0');
controlsHeader.append(monthselect);
controlsHeader.append(yearselect);
controlsHeader.append('\u00a0');
controlsHeader.append(jQuery('<span class="nextMonth"></span>').text('»'));
controlsRow.append(controlsHeader);
jQuery("thead",table).append(controlsRow);

var daysRow = jQuery('<tr class="days"></tr>');
for (var d = 0; d < 7; d++) {
daysRow.append(jQuery('<th></th>').text(l10n_cal_days[d]));
}
jQuery("thead",table).append(daysRow);

var tfootRow = jQuery('<tr></tr>');
tfootRow.append(jQuery('<td colspan="2"></td>').append(jQuery('<span class="today"></span>').text(l10n_cal_today)));
tfootRow.append(jQuery('<td colspan="3"></td>').html('&nbsp;'));

Check warning

Code scanning / ESLint

Direct calls to method `html()` often (e.g. in jQuery framework) manipulate DOM without any sanitization and should be avoided. Use document.createElement() or similar methods instead. Warning

Do not write to DOM directly using jQuery html() method
tfootRow.append(jQuery('<td colspan="2"></td>').append(jQuery('<span class="close"></span>').text(l10n_cal_close)));
jQuery("tfoot",table).append(tfootRow);

for (var i = 0; i < 6; i++) jQuery("tbody",table).append('<tr><td></td><td></td><td></td><td></td><td></td><td></td><td></td></tr>');
return table;
}
Expand Down
Loading