Set ArgoCD SkipDryRunOnMissingResource sync option for all CRs #45
Draft
haasad wants to merge 1 commit into
Draft
Set ArgoCD SkipDryRunOnMissingResource sync option for all CRs #45haasad wants to merge 1 commit into
haasad wants to merge 1 commit into
Conversation
47e7fd7 to
b601643
Compare
Member
Author
|
@simu we discussed this earlier today, at least that's how interpreted your intention. But wouldn't the bootstrap problem also be covered by projectsyn/component-argocd@e3b8c5d ? |
Member
@haasad yes, the immediate issue with component-argocd is addressed with the other commit, but this will ensure that all components which deploy Espejote resources don't get stuck during bootstrap. Additionally, if we add more Espejote custom resources to component-argocd we won't have to remember to set the sync option on those. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.