Remove role name length assertions#47
Merged
Merged
Conversation
|
🚀 This PR has been released as Triggering workflows 🛠️ Auto tagging enabled with label |
simu
force-pushed
the
fix/generated-rbac-namelength
branch
from
2a01771 to
473a445
Compare
Kubernetes actually doesn't restrict role/clusterrole name length. The actual error I saw previously was that the value of `app.kubernetes.io/name` can't exceed 63 characters. For better UX, we remove the name length assertions again and drop the `app.kubernetes.io/name` label from the supplemental roles and rolebindings since that label isn't really required anyway.
simu
force-pushed
the
fix/generated-rbac-namelength
branch
from
473a445 to
e42b6b2
Compare
bastjan
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kubernetes actually doesn't restrict role/clusterrole name length. The actual error I saw previously was that the value of
app.kubernetes.io/namecan't exceed 63 characters.For better UX, we remove the name length assertions again and instead drop the
app.kubernetes.io/namelabel from the supplemental roles and rolebindings since that label isn't really required anyway.Follow-up for #44
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.