Fix image rendering - #21
Merged
Merged
Conversation
|
🚀 This PR has been released as Triggering workflows 🛠️ Auto tagging enabled with label |
|
🚀 Merging this PR will release Merging will trigger workflows 🛠️ Auto tagging enabled with label |
DebakelOrakel
force-pushed
the
fix/image-registry-rendering
branch
from
June 26, 2026 09:31
24c8675 to
4c94df3
Compare
simu
reviewed
Jun 26, 2026
simu
left a comment
simu
left a comment
Member
There was a problem hiding this comment.
See inline comments for possible simplification.
Also, don't we need to apply the same fix for the other images (nginx and accessLogsExporter)?
Contributor
Author
The others already handled it correctly. I think this was bc the grafana/loki chart handled it differently than the community chart. |
added 2 commits
June 26, 2026 13:14
Correctly appies registry and repository parameters.
DebakelOrakel
force-pushed
the
fix/image-registry-rendering
branch
from
June 26, 2026 11:15
969791d to
8905713
Compare
simu
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correctly appies registry and repository parameters.
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.